cmd/link: allow deriving GNU build ID from Go build ID ID #61469

pks-t · 2023-07-20T08:04:56Z

While it is possible to embed a GNU build ID into the linked
executable by passing -B 0xBUILDID to the linker, the build ID will
need to be precomputed by the build system somehow. This makes it
unnecessarily complex to generate a deterministic build ID as it
either requires the build system to hash all inputs manually or to
build the binary twice, once to compute its hash and once with the GNU
build ID derived from that hash. Despite being complex, it is also
inefficient as it requires the build system to duplicate some of the
work that the Go linker already performs anyway.

Introduce a new argument "gobuildid" that can be passed to -B that
causes the linker to automatically derive the GNU build ID from the Go
build ID. Given that the Go build ID is deterministically computed
from all of its inputs, the resulting GNU build ID should be
deterministic in the same way, which is the desired behaviour.

Furthermore, given that the -B flag currently requires a "0x" prefix
for all values passed to it, using "gobuildid" as value is a backwards
compatible change.

An alternative would be to unconditionally calculate the GNU build ID
unless otherwise specified. This would require some larger rework
though because building the Go toolchain would not converge anymore
due the GNU build ID changing on every stage, which in turn would
cause the Go build ID to change as well.

Fixes #41004

gopherbot · 2023-07-20T08:08:38Z

This PR (HEAD: 12264b2) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/511475.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-07-20T08:14:48Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-20T12:21:48Z

Message from Than McIntosh:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-20T12:28:00Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-20T12:40:20Z

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-20T14:14:11Z

Message from Cherry Mui:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-24T09:22:29Z

Message from Patrick Steinhardt:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-24T14:43:17Z

Message from Cherry Mui:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-25T11:43:58Z

This PR (HEAD: 0360328) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/511475.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-07-25T11:49:40Z

Message from Patrick Steinhardt:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-25T16:27:52Z

Message from Cherry Mui:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-26T14:08:49Z

Message from Patrick Steinhardt:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-26T16:10:57Z

Message from Cherry Mui:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-27T08:17:13Z

This PR (HEAD: 3106d49) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/511475.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-07-27T08:23:11Z

Message from Patrick Steinhardt:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-27T23:29:02Z

Message from Ian Lance Taylor:

Patch Set 3: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-27T23:29:03Z

Message from Gopher Robot:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-27T23:46:24Z

Message from Gopher Robot:

Patch Set 3: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-28T19:03:54Z

Message from Cherry Mui:

Patch Set 3:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-07T07:42:19Z

This PR (HEAD: a49faea) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/511475.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-08-07T07:54:44Z

Message from Patrick Steinhardt:

Patch Set 4:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-07T07:54:45Z

Message from Patrick Steinhardt:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-07T08:01:05Z

Message from Patrick Steinhardt:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-08T14:31:35Z

Message from Michael Pratt:

Patch Set 6: Code-Review+1 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-08T14:37:48Z

Message from Go LUCI:

Patch Set 6:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-09-08T14:22:51Z","revision":"27873d87bb08c58422b861f749b97a8ee1bb397d"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-08T14:37:49Z

Message from Michael Pratt:

Patch Set 6: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-08T14:37:50Z

Message from Go LUCI:

Patch Set 6:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-amd64-newinliner has failed

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-08T14:37:50Z

Message from Go LUCI:

Patch Set 6: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-14T17:55:33Z

Message from Cherry Mui:

Patch Set 6:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-15T06:18:31Z

This PR (HEAD: 82e19d2) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/511475.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-09-15T06:30:27Z

Message from Patrick Steinhardt:

Patch Set 6:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-15T15:46:28Z

Message from Cherry Mui:

Patch Set 7: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-15T15:52:52Z

Message from Go LUCI:

Patch Set 7:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-09-15T15:37:56Z","revision":"a243f0b4c3ce721fd131b84a593d9c818ff42942"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-15T15:59:16Z

Message from Cherry Mui:

Patch Set 7: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-15T15:59:17Z

Message from Go LUCI:

Patch Set 7:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-15T15:59:17Z

Message from Go LUCI:

Patch Set 7: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-15T16:31:27Z

Message from Cherry Mui:

Patch Set 7: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

While it is possible to embed a GNU build ID into the linked executable by passing `-B 0xBUILDID` to the linker, the build ID will need to be precomputed by the build system somehow. This makes it unnecessarily complex to generate a deterministic build ID as it either requires the build system to hash all inputs manually or to build the binary twice, once to compute its hash and once with the GNU build ID derived from that hash. Despite being complex, it is also inefficient as it requires the build system to duplicate some of the work that the Go linker already performs anyway. Introduce a new argument "gobuildid" that can be passed to `-B` that causes the linker to automatically derive the GNU build ID from the Go build ID. Given that the Go build ID is deterministically computed from all of its inputs, the resulting GNU build ID should be deterministic in the same way, which is the desired behaviour. Furthermore, given that the `-B` flag currently requires a "0x" prefix for all values passed to it, using "gobuildid" as value is a backwards compatible change. An alternative would be to unconditionally calculate the GNU build ID unless otherwise specified. This would require some larger rework though because building the Go toolchain would not converge anymore due the GNU build ID changing on every stage, which in turn would cause the Go build ID to change as well. Fixes golang#41004

gopherbot · 2023-09-16T11:12:19Z

This PR (HEAD: 5483305) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/511475.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-09-16T11:18:06Z

Message from Patrick Steinhardt:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-18T16:16:24Z

Message from Cherry Mui:

Patch Set 8: Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-18T16:16:25Z

Message from Go LUCI:

Patch Set 8:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-09-18T16:12:26Z","revision":"3671c830cd4dbc274e57a857628b16793e7680a7"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

While it is possible to embed a GNU build ID into the linked executable by passing `-B 0xBUILDID` to the linker, the build ID will need to be precomputed by the build system somehow. This makes it unnecessarily complex to generate a deterministic build ID as it either requires the build system to hash all inputs manually or to build the binary twice, once to compute its hash and once with the GNU build ID derived from that hash. Despite being complex, it is also inefficient as it requires the build system to duplicate some of the work that the Go linker already performs anyway. Introduce a new argument "gobuildid" that can be passed to `-B` that causes the linker to automatically derive the GNU build ID from the Go build ID. Given that the Go build ID is deterministically computed from all of its inputs, the resulting GNU build ID should be deterministic in the same way, which is the desired behaviour. Furthermore, given that the `-B` flag currently requires a "0x" prefix for all values passed to it, using "gobuildid" as value is a backwards compatible change. An alternative would be to unconditionally calculate the GNU build ID unless otherwise specified. This would require some larger rework though because building the Go toolchain would not converge anymore due the GNU build ID changing on every stage, which in turn would cause the Go build ID to change as well. Fixes #41004 Change-Id: I707c5fc321749c00761643d6cc79d44bf2cd744d GitHub-Last-Rev: 5483305 GitHub-Pull-Request: #61469 Reviewed-on: https://go-review.googlesource.com/c/go/+/511475 Reviewed-by: Cherry Mui <cherryyz@google.com> Reviewed-by: Michael Pratt <mpratt@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

gopherbot · 2023-09-18T16:36:44Z

Message from Cherry Mui:

Patch Set 8: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-18T16:36:45Z

Message from Go LUCI:

Patch Set 8:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-18T16:36:46Z

Message from Go LUCI:

Patch Set 8: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/511475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-18T16:43:41Z

This PR is being closed because golang.org/cl/511475 has been merged.

pks-t force-pushed the pks-gnu-build-id-from-action-id branch from 5f79f18 to 12264b2 Compare July 20, 2023 08:06

pks-t force-pushed the pks-gnu-build-id-from-action-id branch from 12264b2 to 0360328 Compare July 25, 2023 11:40

pks-t force-pushed the pks-gnu-build-id-from-action-id branch from 0360328 to 3106d49 Compare July 27, 2023 08:14

pks-t force-pushed the pks-gnu-build-id-from-action-id branch from 3106d49 to a49faea Compare August 7, 2023 07:38

pks-t changed the title ~~cmd/link: allow deriving GNU build ID from action ID~~ cmd/link: allow deriving GNU build ID from Go build ID ID Aug 7, 2023

pks-t force-pushed the pks-gnu-build-id-from-action-id branch from a49faea to 82e19d2 Compare September 15, 2023 06:17

pks-t force-pushed the pks-gnu-build-id-from-action-id branch from 82e19d2 to 5483305 Compare September 16, 2023 11:12

gopherbot closed this Sep 18, 2023

aalexand mentioned this pull request Jul 30, 2024

runtime/pprof: Go build ID is not recorded in pprof profiles, only GNU build ID #68652

Closed

cmd/link: allow deriving GNU build ID from Go build ID ID #61469

cmd/link: allow deriving GNU build ID from Go build ID ID #61469

Conversation

pks-t commented Jul 20, 2023 • edited Loading

gopherbot commented Jul 20, 2023

gopherbot commented Jul 20, 2023

gopherbot commented Jul 20, 2023

gopherbot commented Jul 20, 2023

gopherbot commented Jul 20, 2023

gopherbot commented Jul 20, 2023

gopherbot commented Jul 24, 2023

gopherbot commented Jul 24, 2023

gopherbot commented Jul 25, 2023

gopherbot commented Jul 25, 2023

gopherbot commented Jul 25, 2023

gopherbot commented Jul 26, 2023

gopherbot commented Jul 26, 2023

gopherbot commented Jul 27, 2023

gopherbot commented Jul 27, 2023

gopherbot commented Jul 27, 2023

gopherbot commented Jul 27, 2023

gopherbot commented Jul 27, 2023

gopherbot commented Jul 28, 2023

gopherbot commented Aug 7, 2023

gopherbot commented Aug 7, 2023

gopherbot commented Aug 7, 2023

gopherbot commented Aug 7, 2023

gopherbot commented Sep 8, 2023

gopherbot commented Sep 8, 2023

gopherbot commented Sep 8, 2023

gopherbot commented Sep 8, 2023

gopherbot commented Sep 8, 2023

gopherbot commented Sep 14, 2023

gopherbot commented Sep 15, 2023

gopherbot commented Sep 15, 2023

gopherbot commented Sep 15, 2023

gopherbot commented Sep 15, 2023

gopherbot commented Sep 15, 2023

gopherbot commented Sep 15, 2023

gopherbot commented Sep 15, 2023

gopherbot commented Sep 15, 2023

gopherbot commented Sep 16, 2023

gopherbot commented Sep 16, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 18, 2023

pks-t commented Jul 20, 2023 •

edited

Loading