-
Notifications
You must be signed in to change notification settings - Fork 18.3k
Closed
Labels
FixPendingIssues that have a fix which has not yet been reviewed or submitted.Issues that have a fix which has not yet been reviewed or submitted.NeedsFixThe path to resolution is known, but the work has not been done.The path to resolution is known, but the work has not been done.OS-Plan9
Milestone
Description
CL 685755 added a new subtest TestLookPath/path=exe/dotdot1
which always fails on Plan 9 builders in this way:
--- FAIL: TestLookPath (0.43s)
dot_test.go:42: . is `/tmp/TestLookPath3081099371/001/testdir`
--- FAIL: TestLookPath/path=exe (0.01s)
--- FAIL: TestLookPath/path=exe/dotdot1 (0.01s)
dot_test.go:210: PATH=
dot_test.go:210: "abc/..": error expected, got nil
dot_test.go:210: "abc/..": path returned should be "". Got "/home/swarming/swarming2/.swarming/w/ir/x/t/go-build579210599/b1944/exec.test"
FAIL
FAIL os/exec 11.258s
Since the CL is described as a security-related fix, it's disappointing to see that it was merged without checking that it worked correctly on all platforms (not just first-class ports).
Metadata
Metadata
Assignees
Labels
FixPendingIssues that have a fix which has not yet been reviewed or submitted.Issues that have a fix which has not yet been reviewed or submitted.NeedsFixThe path to resolution is known, but the work has not been done.The path to resolution is known, but the work has not been done.OS-Plan9