x/tools/gopls: Inline: panic in falcon analysis (unexpected core type)

[adonovan]

#!stacks
"gopanic" && "inline.(*falconState).expr:+90"

Issue created by stacks.

This stack Lpelvw was reported by telemetry:

• crash/crash
• runtime.gopanic:+69,+0x167
• golang.org/x/tools/internal/refactor/inline.(*falconState).expr:+90,+0x2513
• golang.org/x/tools/internal/refactor/inline.(*falconState).stmt.func1:+3,+0x265
• go/ast.inspector.Visit:+1,+0x2a
• go/ast.Walk:+1,+0x4b
• go/ast.walkList[...]:=21,+0x1ebb
• go/ast.Walk:+161,+0x1e68
• go/ast.walkList[...]:=21,+0x23dc
• go/ast.Walk:+178,+0xdf9
• go/ast.Inspect:=372,+0x8e
• golang.org/x/tools/internal/refactor/inline.(*falconState).stmt:+1,+0x17
• golang.org/x/tools/internal/refactor/inline.falcon:+19,+0x248
• golang.org/x/tools/internal/refactor/inline.analyzeParams:+83,+0x8cf
• golang.org/x/tools/internal/refactor/inline.AnalyzeCallee:+244,+0xc7e
• golang.org/x/tools/gopls/internal/golang.inlineCall:+44,+0x47e
• golang.org/x/tools/gopls/internal/golang.ApplyFix:+43,+0x702
• golang.org/x/tools/gopls/internal/server.(*commandHandler).ApplyFix.func1:+1,+0x85
• golang.org/x/tools/gopls/internal/server.(*commandHandler).run.func2:+3,+0x86
• golang.org/x/tools/gopls/internal/server.(*commandHandler).run:+81,+0x582

golang.org/x/tools/gopls@v0.19.1 go1.24.2 linux/amd64 vscode (3)

[gabyhelp]

Related Issues

• x/tools/gopls: ChangeSignature: OOB panic in inlineCall (FuncType.Params inconsistent with Signature) #73912
• x/tools/internal/refactor/inline: panic in needsParens #71486 (closed)
• x/tools/gopls/internal/golang: inline variable: nil panic in inlineVariableOne #74347 (closed)
• x/tools/gopls: ChangeSignature: OOB panic in inline.updateCalleeParams (mismatched syntactic/semantic params) #73913
• x/tools/gopls: Implementation (by signatures): nil panic in dynamicFuncCallType #74305 (closed)
• x/tools/gopls: CodeActions: "end < start" panic #74394
• x/tools/gopls: analysisinternal.ZeroValue crash on (presumably) unsafe.Pointer #70585 (closed)
• x/tools/gopls: panic in inliner (reported by telemetry) #64836 (closed)
• x/tools/gopls: ChangeSignature: crash in in inliner (likely due to ill-formed variadic call) #73187
• x/tools/gopls: Parse: crash in fixInitStmt #72026 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[findleyr]

Reproduced. Fix incoming.

[gopherbot]

Change https://go.dev/cl/684295 mentions this issue: internal/refactor/inline: falcon: only map keys can be variable