x/tools/gopls/internal/telemetry/cmd/stacks: incorrect line number in codesearch link

[adonovan]

In #71659 (comment), there is the following stack frame:

• golang.org/x/tools/gopls/internal/cache.(*action).exec.func3:+3
  (golang.org/x/tools/gopls@v0.18.0-pre.1 go1.23.5 windows/amd64)

The symbol name refers to line 3 of the Report closure, i.e. the "invalid SuggestedFixes" bug report, but the link target is in the middle of a comment.

		Report: func(d analysis.Diagnostic) {
			// Assert that SuggestedFixes are well formed.
			if err := analysisinternal.ValidateFixes(apkg.pkg.FileSet(), analyzer, d.SuggestedFixes); err != nil {
				bug.Reportf("invalid SuggestedFixes: %v", err)         <---- correct location
				d.SuggestedFixes = nil
			}
			diagnostic, err := toGobDiagnostic(posToLocation, analyzer, d)
			if err != nil {
				// Don't bug.Report here: these errors all originate in
				// posToLocation, and we can more accurately discriminate
				// severe errors from benign ones in that function.             <------ actual link target
				event.Error(ctx, fmt.Sprintf("internal error converting diagnostic from analyzer %q", analyzer.Name), err)
				return
			}
			diagnostics = append(diagnostics, diagnostic)
		},

[gabyhelp]

Related Issues

• x/tools/gopls: "internal error converting diagnostic" (bug reported by telemetry) #64547
• x/tools/gopls: "diagnostic location is not among files of package: %s" bug (with analyzer SA4023) #70791
• x/tools/gopls: cgocall analyzer: "token.Pos not within package" bug (reported by telemetry) #66911 (closed)
• gopls/internal/analysis: noresultvalues diagnostic triggers "end > end of file + 1" bug (via telemetry) #68105
• x/tools/gopls: bug in typeCheckImpl reported by telemetry #64320 (closed)
• x/tools/gopls: Analyze bug reported by telemetry #64238 (closed)
• x/tools/go/analysis/passes/unreachable: invalid suggested fix #71659
• x/tools/gopls: off-by-one in diagnostic results? #35116 (closed)
• x/tools/gopls: "could not compute pos to range for %v: %v" bug (reported by telemetry) #65960
• x/tools/gopls: "type checker error %q outside its Fset" bug reported by telemetry #66766

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[prattmic]

In v0.17.1, line 1143 was the third line of cache.(*action).exec.func3 (but is not a call to Reportf). Did stacks fetch the wrong version of the source?

https://cs.opensource.google/go/x/tools/+/refs/tags/gopls/v0.17.1:gopls/internal/cache/analysis.go;l=1143