Skip to content

x/tools/gopls/internal/analysis/modernize: incomplete simplification in appendclipped #71296

Closed
@adonovan

Description

@adonovan

The appendclipped modernizer has an existing test case whose output (after applying a fix) is:

	print(slices.Concat(other[:len(other):len(other)], s, other))      // want "Replace append with slices.Concat"

The first argument should also have been simplified to other. Investigate + fix.

Metadata

Metadata

Assignees

Labels

BugReportIssues describing a possible bug in the Go implementation.RefactoringIssues related to refactoring toolsToolsThis label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions