Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/test/marker: Test/completion/imported-std.txt failures #70362

Closed
gopherbot opened this issue Nov 15, 2024 · 4 comments
Closed

x/tools/gopls/internal/test/marker: Test/completion/imported-std.txt failures #70362

gopherbot opened this issue Nov 15, 2024 · 4 comments
Assignees
@findleyr
Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted. gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test/completion/imported-std.txt"

Issue created automatically to collect these failures.

Example (log):

=== RUN   Test/completion/imported-std.txt
=== PAUSE Test/completion/imported-std.txt

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 15, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test/completion/imported-std.txt"
2024-11-14 23:37 x_tools-gotip-linux-amd64-nocgo tools@c043599d go@f99f5da1 x/tools/gopls/internal/test/marker.Test/completion/imported-std.txt [ABORT] (log) 
=== RUN   Test/completion/imported-std.txt
=== PAUSE Test/completion/imported-std.txt

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Nov 15, 2024
@gopherbot gopherbot added this to the Unreleased milestone Nov 15, 2024
@findleyr
Copy link
Member

Aha, this test requires cgo. Fix incoming...

@findleyr findleyr self-assigned this Nov 15, 2024
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/628017 mentions this issue: gopls/internal/cache: fix handling of cgo standalone files

@findleyr findleyr added the FixPending Issues that have a fix which has not yet been reviewed or submitted. label Nov 15, 2024
@findleyr findleyr removed this from Test Flakes Nov 15, 2024
@findleyr
Copy link
Member

Dupe of #70363.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Nov 15, 2024
gopherbot pushed a commit to golang/tools that referenced this issue Nov 18, 2024
@findleyr
gopls/internal/cache: fix handling of cgo standalone files
60bc93d 
It is not a bug for go/packages to return no packages for standalone
files, if they use cgo and cgo is disabled. There may also be other
scenarios where standalone packages are not produced. In any case,
downgrade the bug report to a normal error.

Also, fix the failing test to require cgo.

Fixes golang/go#70363
Fixes golang/go#70362

Change-Id: I2b8a8b3947e4d7ff6482279540638e13dc9de2b4
Reviewed-on: https://go-review.googlesource.com/c/tools/+/628017
Reviewed-by: Tim King <taking@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findleyr findleyr

Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted. gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@gopherbot @findleyr