Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: crash monitoring broken with telemetry.Start #69681

Closed
findleyr opened this issue Sep 27, 2024 · 3 comments
Closed

x/tools/gopls: crash monitoring broken with telemetry.Start #69681

findleyr opened this issue Sep 27, 2024 · 3 comments
Assignees
@findleyr
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.17.0

Comments

@findleyr
Copy link
Member

Originally reported by @danp in #69552: an observed crash was not recorded in telemetry.

Investigating why, I discovered that in https://go.dev/cl/592017, the codepath to the telemetry child started bypassing the call to counter.Open, and so while the crashmonitor does in fact report a crash, this report goes nowhere.

Of course, this indicates a critical gap in testing coverage of telemetry.Start.

It looks like gopls@v0.16.2 has this bug as well, but gopls@v0.16.1 does not (I had a note to self to investigate why we'd not received any crash reports for gopls@v0.16.2). The go command is unaffected as it wasn't using crash reporting.

Fix incoming.
@findleyr findleyr added this to the gopls/v0.17.0 milestone Sep 27, 2024
@findleyr findleyr self-assigned this Sep 27, 2024
@gabyhelp
Copy link

Related Issues and Documentation

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Sep 27, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/616396 mentions this issue: telemetry: fix automated crash reporting using telemetry.Start

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/616415 mentions this issue: gopls: update x/telemetry to pick up fix for golang/go#69681

gopherbot pushed a commit to golang/tools that referenced this issue Sep 27, 2024
@findleyr @gopherbot
gopls: update x/telemetry to pick up fix for golang/go#69681
18bc032 
Update the x/telemetry dependency to pick up the fix for crash reporting
from golang/go#69681.

For golang/go#69681

Change-Id: Ic8bda6e1e80a5004989567a5e7645ef99cf9130f
Reviewed-on: https://go-review.googlesource.com/c/tools/+/616415
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Robert Findley <rfindley@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
Pinkle-pash added a commit to Pinkle-pash/telemetry that referenced this issue Dec 4, 2024
@Pinkle-pash
telemetry: fix automated crash reporting using telemetry.Start
acc85e1 
Following CL 592017, the child process started by telemetry.Start no
longer opens the counter file, causing crash reports to be dropped on
the floor. Fix this, with a test.

Fixes golang/go#69681

Change-Id: I423533d5b1e2369f13880cecd9137cd7c9239240
Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/616396
Reviewed-by: Alan Donovan <adonovan@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Robert Findley <rfindley@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findleyr findleyr

Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.17.0
Development

No branches or pull requests
3 participants
@gopherbot @findleyr @gabyhelp