Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: breaking change in 1.23rc2 with version constraints in GOPATH mode [1.23 backport] #69094

Closed
gopherbot opened this issue Aug 27, 2024 · 3 comments
Closed

cmd/go: breaking change in 1.23rc2 with version constraints in GOPATH mode [1.23 backport] #69094

gopherbot opened this issue Aug 27, 2024 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases GoCommand cmd/go
Milestone
Go1.23.1

Comments

@gopherbot
Copy link
Contributor

@matloob requested issue #68658 to be considered for backport to the next 1.23 minor release.

@gopherbot please backport this to 1.23. It's necessary to unbreak GOPATH mode with certain build tags
@gopherbot gopherbot added CherryPickCandidate Used during the release process for point releases GoCommand cmd/go labels Aug 27, 2024
@gopherbot gopherbot mentioned this issue Aug 27, 2024
Closed
@gopherbot gopherbot added this to the Go1.23.1 milestone Aug 27, 2024
@matloob
Copy link
Contributor

matloob commented Aug 27, 2024

cc @griesemer

@matloob matloob added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Aug 27, 2024
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/608935 mentions this issue: [release-branch.go1.23] go/types, types2: use max(fileVersion, go1.21) if fileVersion present

gopherbot pushed a commit that referenced this issue Aug 28, 2024
@matloob @prattmic
[release-branch.go1.23] go/types, types2: use max(fileVersion, go1.21…
7afe17b 
…) if fileVersion present

Change the rules for how //go:build "file versions" are applied: instead
of considering whether a file version is an upgrade or downgrade from
the -lang version, always use max(fileVersion, go1.21). This prevents
file versions from downgrading the version below go1.21.  Before Go 1.21
the //go:build version did not have the meaning of setting the file's
langage version.

This fixes an issue that was appearing in GOPATH builds: Go 1.23.0
started providing -lang versions to the compiler in GOPATH mode (among
other places) which it wasn't doing before, and it set -lang to the
toolchain version (1.23). Because the -lang version was greater than
go1.21, language version used to compile the file would be set to the
//go:build file version. //go:build file versions below 1.21 could cause
files that could previously build to stop building.

For example, take a Go file with a //go:build line specifying go1.10.
If that file used a 1.18 feature, that use would compile fine with a Go
1.22 toolchain. But it would produce an error when compiling with the
1.23.0 toolchain because it set the language version to 1.10 and
disallowed the 1.18 feature. This breaks backwards compatibility: when
the build tag was added, it did not have the meaning of restricting the
language version.

For #68658
Fixes #69094

Change-Id: I6cedda81a55bcccffaa3501eef9e2be6541b6ece
Reviewed-on: https://go-review.googlesource.com/c/go/+/607955
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Griesemer <gri@google.com>
(cherry picked from commit aeac0b6)
Reviewed-on: https://go-review.googlesource.com/c/go/+/608935
@gopherbot
Copy link
Contributor Author

Closed by merging CL 608935 (commit 7afe17b) to release-branch.go1.23.

@gabyhelp gabyhelp mentioned this issue Oct 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases GoCommand cmd/go
Projects
None yet
Milestone
Go1.23.1
Development

No branches or pull requests
2 participants
@gopherbot @matloob