Skip to content

x/tools/gopls: enable telemetry prompting for all gopls-backed editors #67821

Open
@hyangah

Description

@hyangah

Gopls's telemetry prompting is currently disabled by default.
Client should enable by either setting an internal setting or by calling the prompt command.
VS Code Go extension calls the command for the user selected based on
the hash of vscode client id, after at least a week has passed since a telemetry-enabled
gopls version runs. We now want to move this sampling and decision making to gopls, too,
and enable the prompting in all editors, not only in vscode.

That means we need to record more info in the prompt file in the gopls config directory.

Requirement:

  • Preserve the info recorded in the prompt file and avoid prompting users again.
  • Do not prompt if the user just started to use gopls. Wait for 1 week.

Some nice-to-haves:

  • VS Code Go extension had been running it for awhile. For consistency in sampling, let gopls use the same hash for vs code users.
  • If possible, migrate the telemetry start time recorded in the VS Code Go extension's memento.

Metadata

Metadata

Assignees

Labels

ToolsThis label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions