Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: add LUCI linux-s390x builder #67307

Open
dmitshur opened this issue May 10, 2024 · 4 comments
Open

x/build: add LUCI linux-s390x builder #67307

dmitshur opened this issue May 10, 2024 · 4 comments
Assignees
@srinivas-pokala
Labels
arch-s390x Issues solely affecting the s390x architecture. Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. new-builder OS-Linux
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

There currently isn't a LUCI builder that tests the linux/s390x port (other than the misc-compile builder, which tests only that the port compiles). This is the tracking issue for it.

The next steps that a builder owner will need to follow to make progress here are documented https://go.dev/wiki/DashboardBuilders#luci-builders.
@dmitshur dmitshur added OS-Linux Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. new-builder arch-s390x Issues solely affecting the s390x architecture. labels May 10, 2024
@dmitshur dmitshur added this to the Unreleased milestone May 10, 2024
@dmitshur dmitshur mentioned this issue May 11, 2024
Open
13 tasks
@srinivas-pokala srinivas-pokala self-assigned this Aug 15, 2024
@dmitshur dmitshur moved this to In Progress in Go Release Aug 16, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/617359 mentions this issue: crypto/internal/fips/sha3: reduce s390x divergence

@srinivas-pokala
Copy link
Contributor

Hostname for the builder: linux-s390x-ibm
csr is attached:
linux-s390x-ibm.csr.txt

@dmitshur
Copy link
Contributor Author

dmitshur commented Oct 4, 2024

Thanks. CC @mknyszek.

@mknyszek mknyszek assigned mknyszek and unassigned srinivas-pokala Oct 4, 2024
@mknyszek
Copy link
Contributor

mknyszek commented Oct 4, 2024

Here's the certificate:
linux-s390x-ibm-1728069494.cert.txt

@mknyszek mknyszek assigned srinivas-pokala and unassigned mknyszek Oct 4, 2024
cpu pushed a commit to cpu/go that referenced this issue Oct 16, 2024
@FiloSottile
crypto/internal/fips/sha3: reduce s390x divergence
cc0612d 
It's a little annoying, but we can fit the IBM instructions on top of
the regular state, avoiding more intrusive interventions.

Going forward we should not accept assembly that replaces the whole
implementation, because it doubles the work to do any refactoring like
the one in this chain.

Also, it took me a while to find the specification of these
instructions, which should have been linked from the source for the next
person who'd have to touch this.

Finally, it's really painful to test this without a LUCI TryBot, per golang#67307.

For golang#69536

Change-Id: I90632a90f06b2aa2e863967de972b12dbaa5b2ae
gopherbot pushed a commit that referenced this issue Oct 28, 2024
@FiloSottile @gopherbot
crypto/internal/fips/sha3: reduce s390x divergence
d75fb40 
It's a little annoying, but we can fit the IBM instructions on top of
the regular state, avoiding more intrusive interventions.

Going forward we should not accept assembly that replaces the whole
implementation, because it doubles the work to do any refactoring like
the one in this chain.

Also, it took me a while to find the specification of these
instructions, which should have been linked from the source for the next
person who'd have to touch this.

Finally, it's really painful to test this without a LUCI TryBot, per #67307.

For #69536

Change-Id: I90632a90f06b2aa2e863967de972b12dbaa5b2ae
Reviewed-on: https://go-review.googlesource.com/c/go/+/617359
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Daniel McCarney <daniel@binaryparadox.net>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srinivas-pokala srinivas-pokala

Labels
arch-s390x Issues solely affecting the s390x architecture. Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. new-builder OS-Linux
Projects
Go Release
Status: In Progress
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@mknyszek @dmitshur @gopherbot @srinivas-pokala