Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/http2: Transport.MaxReadFrameSize #54850

Closed
neild opened this issue Sep 2, 2022 · 6 comments
Closed

x/net/http2: Transport.MaxReadFrameSize #54850

neild opened this issue Sep 2, 2022 · 6 comments

Comments

@neild
Copy link
Contributor

neild commented Sep 2, 2022

HTTP/2 endpoints specify a maximum frame size that they are willing to accept from their peer. The maximum frame size in each direction defaults to 16KiB, and can be set to a higher value in a SETTINGS frame.

The HTTP/2 Server.MaxReadFrameSize configuration knob allows setting the maximum frame size the server will accept. There is no corresponding knob for setting the maximum frame size the client will accept. We should add one. (We should also ensure that users don't need to set this to get good performance, of course.)

package http2
type Transport struct {
	// MaxReadFrameSize optionally specifies the largest frame
	// this transport is willing to read. A valid value is between
	// 16k and 16M, inclusive. If zero or otherwise invalid, a
	// default value is used.
	MaxReadFrameSize uint32
}
@neild
Copy link
Contributor Author

neild commented Sep 2, 2022

Originating in: https://go.dev/issue/47840

@neild neild self-assigned this Sep 2, 2022
@ianlancetaylor ianlancetaylor moved this to Incoming in Proposals Sep 3, 2022
@bradfitz
Copy link
Contributor

Sounds fine to me.

@rsc
Copy link
Contributor

rsc commented Sep 28, 2022

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

@rsc rsc moved this from Incoming to Active in Proposals Sep 28, 2022
@rsc
Copy link
Contributor

rsc commented Oct 6, 2022

Based on the discussion above, this proposal seems like a likely accept.
— rsc for the proposal review group

@rsc rsc moved this from Active to Likely Accept in Proposals Oct 6, 2022
@rsc rsc moved this from Likely Accept to Accepted in Proposals Oct 12, 2022
@rsc
Copy link
Contributor

rsc commented Oct 12, 2022

No change in consensus, so accepted. 🎉
This issue now tracks the work of implementing the proposal.
— rsc for the proposal review group

@rsc rsc changed the title proposal: x/net/http2: Transport.MaxReadFrameSize x/net/http2: Transport.MaxReadFrameSize Oct 12, 2022
@rsc rsc modified the milestones: Proposal, Backlog Oct 12, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/362834 mentions this issue: http2: add Transport.MaxReadFrameSize configuration setting

@dmitshur dmitshur modified the milestones: Backlog, Go1.20 Nov 15, 2022
WeiminShang pushed a commit to WeiminShang/net that referenced this issue Nov 16, 2022
For golang/go#47840.
Fixes golang/go#54850.

Change-Id: I44efec8d1f223b3c2be82a2e11752fbbe8bf2cbf
Reviewed-on: https://go-review.googlesource.com/c/net/+/362834
Run-TryBot: Damien Neil <dneil@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Auto-Submit: Damien Neil <dneil@google.com>
Reviewed-by: Joedian Reid <joedian@golang.org>
@golang golang locked and limited conversation to collaborators Nov 15, 2023
@rsc rsc removed this from Proposals Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants