-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/net/http2: Transport.MaxReadFrameSize #54850
Comments
Originating in: https://go.dev/issue/47840 |
Sounds fine to me. |
This proposal has been added to the active column of the proposals project |
Based on the discussion above, this proposal seems like a likely accept. |
No change in consensus, so accepted. 🎉 |
Change https://go.dev/cl/362834 mentions this issue: |
For golang/go#47840. Fixes golang/go#54850. Change-Id: I44efec8d1f223b3c2be82a2e11752fbbe8bf2cbf Reviewed-on: https://go-review.googlesource.com/c/net/+/362834 Run-TryBot: Damien Neil <dneil@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Damien Neil <dneil@google.com> Reviewed-by: Roland Shoemaker <roland@golang.org> Auto-Submit: Damien Neil <dneil@google.com> Reviewed-by: Joedian Reid <joedian@golang.org>
HTTP/2 endpoints specify a maximum frame size that they are willing to accept from their peer. The maximum frame size in each direction defaults to 16KiB, and can be set to a higher value in a
SETTINGS
frame.The HTTP/2
Server.MaxReadFrameSize
configuration knob allows setting the maximum frame size the server will accept. There is no corresponding knob for setting the maximum frame size the client will accept. We should add one. (We should also ensure that users don't need to set this to get good performance, of course.)The text was updated successfully, but these errors were encountered: