Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime/race: upstream OpenBSD support is removed #52090

Closed
cherrymui opened this issue Mar 31, 2022 · 6 comments
Closed

runtime/race: upstream OpenBSD support is removed #52090

cherrymui opened this issue Mar 31, 2022 · 6 comments
Labels
FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Milestone
Go1.19

Comments

@cherrymui
Copy link
Member

LLVM TSAN removed OpenBSD support ( https://reviews.llvm.org/rG53065c543fe3f1e7913c9e8f2487d76034afa249 )
What do we do for the race detector on OpenBSD? Do we want to remove it, or try to add it back to LLVM?

cc @dvyukov @4a6f656c @golang/runtime
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/397494 mentions this issue: runtime/race: update syso files to new TSAN runtime (v3)

@beoran
Copy link

beoran commented Mar 31, 2022

Why was it even dropped? It is not very clear from the issue above.

@qbit
Copy link
Member

qbit commented Apr 1, 2022

I added the initial bits for llvm. No clue why they added it - I will ask.

My pref is to keep it enabled in Go if at all possible. I use the feature pretty regularly.

@randall77
Copy link
Contributor

For now we can just not update TSAN on openbsd. The updates we want to do are mostly performance, so it is ok if it isn't available everywhere (the 8192 goroutine limit might be annoying if it is gone everywhere else, though).

Longer term that isn't a solution, though. At some point we'd have to either fix openbsd support or drop the openbsd race detector.

@dvyukov
Copy link
Member

dvyukov commented Apr 1, 2022

Honestly, I don't know what happened. But it was removed from everywhere, not just tsan.
It seems that the simplest option is not update OpenBSD runtime.

gopherbot pushed a commit that referenced this issue Apr 1, 2022
@cherrymui
runtime/race: update syso files to new TSAN runtime (v3)
995a604 
Following CL 333529, update syso files for other architectures.

Windows/AMD64 is not updated, waiting for Than for C toolchain
updates.

OpenBSD/AMD64 is not updated as upstream LLVM TSAN removed OpenBSD
support (#52090).

Linux/PPC64LE is not updated due to a test failure. Will look into
it.

Change-Id: I46441fd3bb0f2c9e372d3e7fd43744ffafaf87a1
Reviewed-on: https://go-review.googlesource.com/c/go/+/397494
Trust: Cherry Mui <cherryyz@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
@cherrymui cherrymui added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Apr 5, 2022
@cherrymui cherrymui added this to the Go1.19 milestone Apr 5, 2022
@ianlancetaylor
Copy link
Member

I don't think there is anything we can do here, other than carry forward the old OpenBSD race support, so closing this issue.

@golang golang locked and limited conversation to collaborators Jun 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Projects
Release Blockers
Status: Done
Milestone
Go1.19
Development

No branches or pull requests
7 participants
@qbit @beoran @dvyukov @ianlancetaylor @randall77 @gopherbot @cherrymui