Skip to content

test: all codegen tests are skipped #48247

Closed
@mundaym

Description

@mundaym

Apologies if this is a duplicate issue, I couldn't find an appropriate one. I was surprised by this behaviour so I wanted to make sure it was flagged even if it is behaving as expected during the register ABI transition.

I think this behaviour was introduced by CL 320609. The issue can be worked around (albeit with a test failure on amd64) by applying the following patch:

diff --git a/test/run.go b/test/run.go
index 76621d9242..256dd04992 100644
--- a/test/run.go
+++ b/test/run.go
@@ -771,7 +771,7 @@ func (t *test) run() {
                t.initExpectFail(hasGFlag)
 
                switch tool {
-               case Build, Run:
+               case Build, Run, AsmCheck:
                        // ok; handled in goGcflags
 
                case Compile:

Is it worth skipping any failing tests explicitly and then re-enabling the rest? Most of the tests pass fine.

What version of Go are you using (go version)?

$ go version go version devel go1.18-50c69cc3a9 Wed Sep 8 06:59:06 2021 +0000 linux/amd64

Does this issue reproduce with the latest release?

Not tried.

What operating system and processor architecture are you using (go env)?

go env Output
$ go env

What did you do?

cd test
../bin/go run run.go -v codegen

What did you expect to see?

Tests executing.

What did you see instead?

Tests skipped:

excl    codegen/addrcalc.go
ok      codegen/addrcalc.go     0.000s
excl    codegen/alloc.go
ok      codegen/alloc.go        0.000s
excl    codegen/arithmetic.go
ok      codegen/arithmetic.go   0.000s
excl    codegen/bitfield.go
ok      codegen/bitfield.go     0.000s
excl    codegen/bits.go
ok      codegen/bits.go 0.000s
excl    codegen/bool.go
ok      codegen/bool.go 0.000s
excl    codegen/clobberdead.go
ok      codegen/clobberdead.go  0.000s
excl    codegen/clobberdeadreg.go
ok      codegen/clobberdeadreg.go       0.000s
excl    codegen/compare_and_branch.go
ok      codegen/compare_and_branch.go   0.000s
excl    codegen/comparisons.go
ok      codegen/comparisons.go  0.000s
excl    codegen/condmove.go
ok      codegen/condmove.go     0.000s
excl    codegen/copy.go
ok      codegen/copy.go 0.000s
excl    codegen/floats.go
ok      codegen/floats.go       0.000s
excl    codegen/fuse.go
ok      codegen/fuse.go 0.000s
excl    codegen/issue22703.go
ok      codegen/issue22703.go   0.000s
excl    codegen/issue25378.go
ok      codegen/issue25378.go   0.000s
excl    codegen/issue31618.go
ok      codegen/issue31618.go   0.000s
excl    codegen/issue33580.go
ok      codegen/issue33580.go   0.000s
excl    codegen/issue38554.go
ok      codegen/issue38554.go   0.000s
excl    codegen/issue42610.go
ok      codegen/issue42610.go   0.000s
excl    codegen/issue48054.go
ok      codegen/issue48054.go   0.000s
excl    codegen/logic.go
ok      codegen/logic.go        0.000s
excl    codegen/mapaccess.go
ok      codegen/mapaccess.go    0.000s
excl    codegen/maps.go
ok      codegen/maps.go 0.000s
excl    codegen/math.go
ok      codegen/math.go 0.000s
excl    codegen/mathbits.go
ok      codegen/mathbits.go     0.000s
excl    codegen/memcombine.go
ok      codegen/memcombine.go   0.000s
excl    codegen/memops.go
ok      codegen/memops.go       0.000s
excl    codegen/noextend.go
ok      codegen/noextend.go     0.000s
excl    codegen/race.go
ok      codegen/race.go 0.000s
excl    codegen/regabi_regalloc.go
ok      codegen/regabi_regalloc.go      0.000s
excl    codegen/retpoline.go
ok      codegen/retpoline.go    0.000s
excl    codegen/rotate.go
ok      codegen/rotate.go       0.000s
excl    codegen/select.go
ok      codegen/select.go       0.000s
excl    codegen/shift.go
ok      codegen/shift.go        0.000s
excl    codegen/shortcircuit.go
ok      codegen/shortcircuit.go 0.000s
excl    codegen/slices.go
ok      codegen/slices.go       0.000s
excl    codegen/smallintiface.go
ok      codegen/smallintiface.go        0.000s
excl    codegen/spectre.go
ok      codegen/spectre.go      0.000s
excl    codegen/stack.go
ok      codegen/stack.go        0.000s
excl    codegen/strings.go
ok      codegen/strings.go      0.000s
excl    codegen/structs.go
ok      codegen/structs.go      0.000s
excl    codegen/switch.go
ok      codegen/switch.go       0.000s
excl    codegen/zerosize.go
ok      codegen/zerosize.go     0.000s

Metadata

Metadata

Assignees

No one assigned

    Labels

    FrozenDueToAgeNeedsFixThe path to resolution is known, but the work has not been done.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions