cmd/link: -buildmode=c-shared not supported on linux/mips64le #43264

Mengkzhaoyun · 2020-12-18T11:48:13Z

What version of Go are you using (`go version`)?

$ go version
1.15.6

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (`go env`)?

go env Output

$ go env
GO111MODULE=""
GOARCH="mips64le"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOENV="/root/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="mips64le"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/go"
GOPRIVATE=""
GOPROXY="https://goproxy.cn,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_mips64le"
GCCGO="gccgo"
GOMIPS64="hardfloat"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/go/src/github.com/cilium/cilium/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -mabi=64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build215838537=/tmp/go-build -gno-record-gcc-switches"

What did you do?

When I tried to migrate Cilium to the mips64le (loongnix) platform, I got an error, among others, when I compiled a class library, Proxylib, and found that Cilium was handling it as a .so file.
Here is the compile command

$ CGO_ENABLED=1 go build -mod=vendor -ldflags ' -X "github.com/cilium/cilium/pkg/version.ciliumVersion=1.9.1 6857a8d2a 2020-12-18T01 :24:42+08:00" -s -w -X "github.com/cilium/cilium/pkg/envoy.RequestedEnvoyVersionSHA=1177896bebde79915fe5f9092409bf0254084b4e" -X " github.com/cilium/cilium/pkg/datapath/loader.DatapathSHA=3d9461ac3d8ae0b334f319c93e10ddea336d8617" -extldflags -Wl,-soname, libcilium.so.1' -tags=osusergo -o libcilium.so.1 -buildmode=c-shared
-buildmode=c-shared support on linux/mips64le

Since -buildmod=c-shared is used, this buildmod prompt does not support building on linux/mips64le, does anyone have any good solutions?

What did you expect to see?

-buildmode=c-shared support on linux/mips64le

What did you see instead?

-buildmode=c-shared not supported on linux/mips64le

The text was updated successfully, but these errors were encountered:

XiaodongLoong · 2020-12-22T09:10:41Z

I have analyzed this issue, and I try to develop this feature, but I have not completed it yet.
I will do it.

ianlancetaylor · 2020-12-22T21:07:07Z

@XiaodongLoong Thanks.

XiaodongLoong · 2021-03-24T03:07:15Z

@ianlancetaylor I meet a issue when I develop the -buildmod=c-shared featrue on linux/mips64le port. Could you give me a hint to fix this issule?
I just open some switches that intercept the feature on linux/mips64le port, and execute go build -a -x -work -buildmod=c-shared xxx.go the following error occors:

/root/go/pkg/tool/linux_mips64le/link -o $WORK/b001/exe/a.out -importcfg $WORK/b001/importcfg.link -installsuffix shared -buildmode=c-shared -buildid=7oc0eGeuITC04x1PL6YA/zGmTkGzcjMksVKPwtCJC/FipDBPEiHap1g6M81mW7/7oc0eGeuITC04x1PL6YA -extld=gcc $WORK/b001/_pkg_.a
# command-line-arguments
/root/go/pkg/tool/linux_mips64le/link: running gcc failed: exit status 1
collect2: fatal error: ld terminated with signal 10 [Bus error], core dumped
compilation terminated.
/usr/bin/ld: /tmp/go-link-020946183/go.o: relocation R_MIPS_26 against `a local symbol' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: BFD (GNU Binutils for Debian) 2.31.1 assertion fail ../../bfd/elfxx-mips.c:6550
/usr/bin/ld: BFD (GNU Binutils for Debian) 2.31.1 assertion fail ../../bfd/elfxx-mips.c:6550
/usr/bin/ld: BFD (GNU Binutils for Debian) 2.31.1 assertion fail ../../bfd/elfxx-mips.c:6550

ianlancetaylor · 2021-03-24T04:01:53Z

This is only a guess, but my first thought would be that (*ctxt0).asmout in cmd/internal/obj/mips/asm0.go needs to check c.ctxt.Flag_shared, and, if that is true, not set rel.Type to objabi.R_CALLMIPS. It needs to generate a position independent relocation instead. Look at C code and see how the assembly differs when using -fPIC; the code in mips/asm0.go will likely need to do something similar. Also look at how other cmd/internal/obj/ARCH/asm*.go files handle Flag_shared.

gopherbot · 2021-08-02T08:28:10Z

Change https://golang.org/cl/339049 mentions this issue: cmd/internal: support -buildmode=c-shared on linux/mips64le

gopherbot · 2021-08-02T08:28:28Z

Change https://golang.org/cl/339051 mentions this issue: runtime: support -buildmode=c-shared on linux/mips64le

gopherbot · 2021-08-02T08:28:29Z

Change https://golang.org/cl/339050 mentions this issue: cmd/compile: support -buildmode=c-shared on linux/mips64le

XiaodongLoong · 2021-08-02T08:56:27Z

@ianlancetaylor I have completed this work, thanks for your guidance.
It is OK on test cases from https://github.com/vladimirvivien/go-cshared-examples and Cilium.

gopherbot · 2021-08-02T12:37:21Z

Change https://golang.org/cl/339069 mentions this issue: cmd/link: support -buildmode=c-shared on linux/mips64le

gopherbot · 2021-08-02T13:02:11Z

Change https://golang.org/cl/339052 mentions this issue: cmd/link: support -buildmode=c-shared on linux/mips64le

gopherbot · 2021-09-09T08:16:39Z

Change https://golang.org/cl/348734 mentions this issue: cmd/link: support -buildmode=c-shared on linux/mips64le

gopherbot · 2021-09-09T08:16:39Z

Change https://golang.org/cl/348733 mentions this issue: cmd/internal: support -buildmode=c-shared on linux/mips64le

gopherbot · 2021-09-09T08:16:40Z

Change https://golang.org/cl/348732 mentions this issue: cmd/compile: support -buildmode=c-shared on linux/mips64le

gopherbot · 2021-09-09T08:16:41Z

Change https://golang.org/cl/348735 mentions this issue: runtime: support -buildmode=c-shared on linux/mips64le

gopherbot · 2021-10-09T02:59:48Z

Change https://golang.org/cl/354890 mentions this issue: cmd/internal/sys: open c-shared feature on linux/mips64le

XiaodongLoong · 2021-10-25T09:52:36Z

@ianlancetaylor @cherrymui PTAL, Thanks!

XiaodongLoong · 2022-02-11T09:01:00Z

A gentle ping. @ianlancetaylor @cherrymui

cherrymui · 2022-02-11T15:02:25Z

We're still in the release freeze for Go 1.18. Will review once the tree opens for 1.19. Thanks.

XiaodongLoong · 2022-03-17T11:01:13Z

@cherrymui Thanks! I rebased the code.

XiaodongLoong · 2022-03-22T06:11:21Z

A gentle ping. @ianlancetaylor @cherrymui

XiaodongLoong · 2022-04-18T13:07:41Z

A gentle ping.
Thanks! ❤️

XiaodongLoong · 2022-06-15T08:03:25Z

Sorry for the delay, the CLs are ready again. I expect a CR. Thanks!

cherrymui · 2022-06-15T14:18:14Z

Thanks @XiaodongLoong . We're in the freeze for Go 1.19 release, so we cannot check them in until the tree opens for Go 1.20 development. The reviews can and will continue during the freeze.

XiaodongLoong · 2022-06-16T01:05:51Z

OK, Thanks! 👍

gopherbot · 2022-06-25T07:52:11Z

Change https://go.dev/cl/414137 mentions this issue: cmd/go/internal/work: add GOBUILDMODE_shared macro to support c-shared buildmode on mips64{,le}

gopherbot · 2022-06-25T07:52:12Z

Change https://go.dev/cl/414136 mentions this issue: cmd/compile/internal/ssa: reserve R25 register for PIC code on mips64{,le}

XiaodongLoong · 2022-08-10T09:18:59Z

@cherrymui
When I debug the "runtime.load_g" function, I find that call C function "___tls_get_addr" directly:

// src/runtime/tls_mips64x.s
MOVV	runtime·tls_g(SB), g  // in GD mode, get TLS address through ___tls_get_addr

I think it is not right, "___tls_get_addr" function should be wrapped by cgo. Then call the C funtion "___tls_get_addr" through the wrapper. And I want to hear from you.
Thanks.

XiaodongLoong · 2023-04-20T01:14:00Z

I rebased code. PTAL. Thanks!

XiaodongLoong · 2023-04-21T08:19:31Z

@cherrymui @ianlancetaylor ping.

The modification of these rules is optimization to load/store global variables. If there are a sequence of loads/stores nearby a global variable address, the address can only be loaded from GOT once instead of every time. For #43264 Change-Id: Idedaf6c81f085955371320f51bca148ffb42a2d8 Reviewed-on: https://go-review.googlesource.com/c/go/+/348732 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by: Ian Lance Taylor <iant@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Ian Lance Taylor <iant@google.com> Auto-Submit: Ian Lance Taylor <iant@google.com>

cherrymui · 2023-07-05T14:30:08Z

@XiaodongLoong Sorry for getting back to you late. I don't think we want to call ___tls_get_addr via cgo. The cgo wrappers are heavy-duty and are mostly for calling C functions from user code. In the runtime, given how special ___tls_get_addr is, we should call it directly. That said, we probably should call it once at startup (or at thread entry if the result is thread dependent), and save the result somewhere, instead of calling it every time in load_g and save_g.

XiaodongLoong · 2023-07-07T08:07:54Z

I am also very sorry, because I am busy with the development work in the company, I did not update the patches in time. I will update the patch as soon as possible.

Thanks!

XiaodongLoong · 2023-07-12T15:04:23Z

Rebase code, PTAL.
Thanks. : )

XiaodongLoong · 2023-12-09T13:11:04Z

I'm very sorry, I don't have enough time to update the CLs and will abandon these CLs. Anyone can continue to complete this work. Thanks.

ianlancetaylor changed the title ~~-buildmode=c-shared not supported on linux/mips64le~~ cmd/link: -buildmode=c-shared not supported on linux/mips64le Dec 18, 2020

ianlancetaylor added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 18, 2020

ianlancetaylor added this to the Backlog milestone Dec 18, 2020

ianlancetaylor added the help wanted label Dec 18, 2020

This comment was marked as duplicate.

Sign in to view

XiaodongLoong mentioned this issue Oct 12, 2021

access: want to access builder machine by Gomote tool #48917

Closed

XiaodongLoong added the arch-mips label Jun 15, 2022

XiaodongLoong added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jun 15, 2022

seankhliao mentioned this issue Oct 10, 2022

when i use cgo on linux/mips64 to build a dy library,some error like "compile: linux/mips64le does not support -shared",but darwin/arm64 or linux/amd64 never happend. #56122

Closed

moloch-- mentioned this issue Jan 9, 2023

rpc error: code = Unavailable desc = error reading from server: EOF BishopFox/sliver#1063

Open

mengzhuo mentioned this issue Apr 12, 2023

cmd/compile: buildmode c-archive not supported on linux/mips64le #59561

Open

23083940 mentioned this issue Apr 12, 2023

cmd/compiler:-buildmode=c-achived not supported on linux/mips64le #59565

Closed

This comment was marked as spam.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as duplicate.

Sign in to view

cmd/link: -buildmode=c-shared not supported on linux/mips64le #43264

cmd/link: -buildmode=c-shared not supported on linux/mips64le #43264

Comments

Mengkzhaoyun commented Dec 18, 2020

What version of Go are you using (go version)?

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

What did you do?

What did you expect to see?

What did you see instead?

XiaodongLoong commented Dec 22, 2020 • edited Loading

This comment was marked as duplicate.

ianlancetaylor commented Dec 22, 2020

XiaodongLoong commented Mar 24, 2021 • edited Loading

ianlancetaylor commented Mar 24, 2021

gopherbot commented Aug 2, 2021

gopherbot commented Aug 2, 2021

gopherbot commented Aug 2, 2021

XiaodongLoong commented Aug 2, 2021 • edited Loading

gopherbot commented Aug 2, 2021

gopherbot commented Aug 2, 2021

gopherbot commented Sep 9, 2021

gopherbot commented Sep 9, 2021

gopherbot commented Sep 9, 2021

gopherbot commented Sep 9, 2021

gopherbot commented Oct 9, 2021

XiaodongLoong commented Oct 25, 2021

XiaodongLoong commented Feb 11, 2022

cherrymui commented Feb 11, 2022

XiaodongLoong commented Mar 17, 2022

XiaodongLoong commented Mar 22, 2022

XiaodongLoong commented Apr 18, 2022 • edited Loading

XiaodongLoong commented Jun 15, 2022

cherrymui commented Jun 15, 2022

XiaodongLoong commented Jun 16, 2022

gopherbot commented Jun 25, 2022

gopherbot commented Jun 25, 2022

XiaodongLoong commented Aug 10, 2022

XiaodongLoong commented Apr 20, 2023

XiaodongLoong commented Apr 21, 2023

This comment was marked as spam.

cherrymui commented Jul 5, 2023

XiaodongLoong commented Jul 7, 2023

XiaodongLoong commented Jul 12, 2023

This comment was marked as off-topic.

This comment was marked as duplicate.

This comment was marked as duplicate.

XiaodongLoong commented Dec 9, 2023

What version of Go are you using (`go version`)?

What operating system and processor architecture are you using (`go env`)?

XiaodongLoong commented Dec 22, 2020 •

edited

Loading

XiaodongLoong commented Mar 24, 2021 •

edited

Loading

XiaodongLoong commented Aug 2, 2021 •

edited

Loading

XiaodongLoong commented Apr 18, 2022 •

edited

Loading