time: quote original text in error returned by ParseDuration

[bruce-ricard]

I am trying to parse some time strings using the standard library. I am trying to parse the time "for breakfast" (literally).

What did you expect to see?

I would expect to see an error message explaining clearly what I did wrong.

What did you see instead?

time: invalid duration for breakfast

That's not very helpful.

time: invalid duration "for breakfast"

would be highly more useful for debugging.

Please think of using quotation marks for quoted text when writing natural language like English.

This part of the code in particular, contains quite a few occurrences of quoted text without quotation marks.

I am happy to submit a PR if you agree this is a good change.

[ianlancetaylor]

I see that time.Parse returns a time.ParseError which does quote the value, so, sure, we should do this. This doesn't need to be a proposal, so retitling.

[obeyda]

hi, I would like to help, can i work on this?

[ianlancetaylor]

@obeyda Thanks for offering. In this case it seems like @bruce-ricard is already planning to send in a change, according to the initial bug submission.

[bruce-ricard]

@obeyda if you want to help and work on it, go ahead. I can help you by reviewing your change if you want to. Let me know.

[obeyda]

@bruce-ricard sure thing, I'll start working on this and submit a CL.

[gopherbot]

Change https://golang.org/cl/227878 mentions this issue: time: quote original values in returned errors