Closed
Description
This is a follow-on to #26404 and #29228.
When a binary is build from within a module's source tree, the output from runtime/debug.ReadBuildInfo
currently reports that module as having version (devel)
.
If the source tree is a pristine checkout from a version-control system — or is within the (read-only) module cache — we could instead interrogate the version-control system to find the corresponding version or pseudo-version to embed.
However, that has a couple of caveats:
- It would require us to run VCS commands within the user's source tree. Historically, running VCS commands has been a source of entirely too many
go
command vulnerabilities, so we would really like to avoid issuing VCS commands except when they are absolutely necessary. - Given a commit, we can produce a pseudo-version for that commit, but we can't tell whether that commit has been published to the origin. It would be nice to preserve the invariant that only published versions are advertised in debug info, but that may incur an extra network fetch.
- Within a module, we apply that module's replacements and exclusions, and the user's VCS checkout may also have applied some transformations.
(devel)
currently provides a clue that those module-specific changes are in effect: if we were to indicate an explicit version instead, we would need to provide some way to indicate that replacements and exclusions were applied.
(CC @jayconrod @rsc @hyangah)