x/tools/imports: does not know about "syscall/js"

[dmitshur]

I've recently sent CL 134176 to update zstdlib.go (the generated file that contains information about the Go standard library) to include the new Go 1.11 API additions.

However, syscall/js package wasn't added to the GOROOT/api/go1.11.txt file that is used to generate zstdlib.go, so that's not enough to get syscall/js support into goimports.

Does anyone know if excluding syscall/js package from api/go1.11.txt was an intentional decision (because syscall/js is considered experimental and exempt from the Go compatibility promise), or an unintentional outcome?

If the latter, we should resolve this issue by first updating api/go1.11.txt, then regenerating imports.

If the former, then we need to make a decision of whether x/tools/imports should know about syscall/js anyway. If so, we can do some custom work here to get it in. I've done similar stuff for a copy of imports used by the GopherJS Playground, so I'm happy to do it.

/cc @neelance @bradfitz @josharian @andybons

[gopherbot]

Change https://golang.org/cl/134176 mentions this issue: imports: update zstdlib to Go 1.11

[bradfitz]

I tried to add it to API/go1.11.txt but it was after the freeze and it ended up nontrivial so I didn't rush it.

For now I'd hard code the entries in goimports.

[gopherbot]

Change https://golang.org/cl/170014 mentions this issue: imports: add syscall/js API to zstdlib.go