Skip to content

x/build/cmd/gopherbot: ignore versions in other paragraphs of backport requests #27489

Open
@bcmills

Description

@bcmills

In #27486 (comment), I attempted to set up a backport issue for Go 1.11. However, apparently because I mentioned “from 1.9 or 1.10” in the justification, gopherbot constructed a backport issue for 1.10 too.

I think we should make gopherbot ignore versions that are separated from the first version in the comment by any punctuation other than a comma. (However, we should be careful not to stop after a period that appears as part of a version string.)

So, for example:
@gopherbot, p—— backport to Go 1.11: this is a regression from 1.9. should backport to 1.11 only.
@gopherbot, p—— backport to Go 1.11, and possibly 1.10: this is a bad runtime bug. should backport to both 1.11, 1.10.

(CC @FiloSottile )

Metadata

Metadata

Assignees

No one assigned

    Labels

    BackportIssues created for requesting a backport of a change to a previous Go version.Buildersx/build issues (builders, bots, dashboards)FeatureRequestIssues asking for a new feature that does not need a proposal.FrictionNuisances that make good candidates for our "friction" fix-it weeksNeedsFixThe path to resolution is known, but the work has not been done.

    Type

    No type

    Projects

    Status

    Planned

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions