Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: inconsistency in supported OS X versions #16625

Closed
0xmohit opened this issue Aug 6, 2016 · 8 comments
Closed

website: inconsistency in supported OS X versions #16625

0xmohit opened this issue Aug 6, 2016 · 8 comments

Comments

@0xmohit
Copy link
Contributor

0xmohit commented Aug 6, 2016

https://golang.org/dl/ mentions:

Apple OS X
OS X 10.8 or later, Intel 64-bit processor

https://golang.org/doc/install says:

Official binary distributions are available for ...
Mac OS X (10.7 and above)

@bradfitz
Copy link
Contributor

bradfitz commented Aug 6, 2016

And later down the page, it says the requirements for compiling from source are "Mac OS X 10.7 or later".

I seem to recall that 10.7 is the minimum requirement for building for source, but somehow the binaries we produce (or the packaging) requires 10.8. I forget the details. @adg?

But the first mistake you cited is easy to fix at least.

@gopherbot
Copy link
Contributor

CL https://golang.org/cl/25548 mentions this issue.

gopherbot pushed a commit that referenced this issue Aug 6, 2016
Updates #16625

Change-Id: Icac6705828bd9b29379596ba64b34d922b9002c3
Reviewed-on: https://go-review.googlesource.com/25548
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@bradfitz
Copy link
Contributor

bradfitz commented Aug 8, 2016

I kept this bug open (using "Updates" in the commit message) so we can figure out what the story with source vs binary release supported versions is on OS X. I was waiting for @adg.

@bradfitz bradfitz reopened this Aug 8, 2016
@quentinmit quentinmit added this to the Go1.7Maybe milestone Aug 8, 2016
@quentinmit
Copy link
Contributor

Okay, I'll tag this for 1.7 then, hopefully we can get the docs right before we release.

@adg
Copy link
Contributor

adg commented Aug 8, 2016

I don't remember anymore.
I guess we'll have to test it to make sure.

@bradfitz
Copy link
Contributor

bradfitz commented Aug 8, 2016

I'll try a build on OS X 10.7 and see what happens.

madeye pushed a commit to shadowsocks/go that referenced this issue Aug 10, 2016
Updates golang#16625

Change-Id: Icac6705828bd9b29379596ba64b34d922b9002c3
Reviewed-on: https://go-review.googlesource.com/25548
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@quentinmit quentinmit modified the milestones: Go1.7Maybe, Go1.8Maybe Aug 25, 2016
@bradfitz
Copy link
Contributor

bradfitz commented Sep 9, 2016

Just tried OS X 10.7. It doesn't even compile:

crypto/x509
# crypto/x509
crypto/x509/root_cgo_darwin.go: In function 'FetchPEMRoots':
crypto/x509/root_cgo_darwin.go:97: error: 'for' loop initial declaration used outside C99 mode
crypto/x509/root_cgo_darwin.go:106: error: 'for' loop initial declaration used outside C99 mode
crypto/x509/root_cgo_darwin.go:114: error: 'SecCertificateCopyNormalizedSubjectContent' is unavailable (declared at /System/Library/Frameworks/Security.framework/Headers/SecCertificate.h:460)
crypto/x509/root_cgo_darwin.go:119: error: 'SecCertificateCopyNormalizedIssuerContent' is unavailable (declared at /System/Library/Frameworks/Security.framework/Headers/SecCertificate.h:443)
database/sql/driver
database/sql
encoding

I'm sure we can work around it, but there's no point. And we don't want to run builders for OS X 10.{7,8,9,10,11,12}. Too many. 8 is old enough. Plus I still recall that 7 (Lion) leaked pipes in exec or something.

I'll fix the docs.

@bradfitz bradfitz self-assigned this Sep 9, 2016
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/28870 mentions this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants