database/sql: confusing documentation for DefaultParameterConverter

[johto]

Hi,

In the documentation for DefaultParameterConvert we have this passage (emphasis mine):

DefaultParameterConverter returns the given value directly if IsValue(value).
Otherwise integer type are converted to int64, floats to float64, and strings to
[]byte. Other types are an error.

However, if we look at the code, even all the way back to 1.0 IsValue has returned true for string. Thus, I don't see how a string could ever be converted to []byte.

Am I misreading this, or is the documentation incorrect?

[chakrit]

@johto I think that was meant to catch stuff like type MyStr string ?

[chakrit]

@johto http://play.golang.org/p/3jRNZpgqBV

[chakrit]

I get []byte all the time whenever I have a special cased string type (such as those for enums or values that need special treatment like phone numbers or emails.)

[johto]

Oh, so it's about the underlying type when the type returns false for IsValue(). Can we make it explicitly say that?

[ianlancetaylor]

CC @bradfitz

[gopherbot]

CL https://golang.org/cl/18520 mentions this issue.