Skip to content

Commit a295b3c

Browse files
committed
test: re-enable AsmCheck tests for types2-based frontends
run.go has logic for being able to run tests with various -G flags, but not all test types (in particular, "asmcheck" tests) support configuring non-default -G levels. The intention was that these tests would continue running in the default mode (at the time -G=0), but at some point it seems like we accidentally disabled them all together (if it ever worked correctly in the first place). Fixes #48247. Change-Id: I13917cb0012cbe522d29b23b888de6136872ead4 Reviewed-on: https://go-review.googlesource.com/c/go/+/348671 Trust: Matthew Dempsky <mdempsky@google.com> Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Michael Munday <mike.munday@lowrisc.org>
1 parent 66f0d35 commit a295b3c

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

test/run.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -780,11 +780,13 @@ func (t *test) run() {
780780
}
781781

782782
default:
783-
// we don't know how to add -G for this test yet
784-
if *verbose {
785-
fmt.Printf("excl\t%s\n", t.goFileName())
783+
if t.glevel != CompilerDefaultGLevel {
784+
// we don't know how to add -G for this test yet
785+
if *verbose {
786+
fmt.Printf("excl\t%s\n", t.goFileName())
787+
}
788+
return false
786789
}
787-
return false
788790
}
789791

790792
return true

0 commit comments

Comments
 (0)