This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
remove getGOPATHS; cleanup #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibrasho
reviewed
Jun 22, 2017
context.go
Outdated
| // } | ||
| // | ||
| // SetPaths sets the WorkingDir and GOPATHs fields. If GOPATHs are omitted, then | ||
| // the $GOPATH environment variable, and the default GOPATH are checked - in that order. |
There was a problem hiding this comment.
"are checked" doesn't really explain what's happening.
How about something along these lines?
// SetPaths sets the WorkingDir and GOPATHs fields. If GOPATHs is empty, then
// the GOPATH environment variable (or the default GOPATH) is used instead.
|
Thanks for simplifying it 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
This change:
getGOPATHsfunctionSetPathsSetPathsWhich issue(s) does this PR fix?
Related #672