This repository was archived by the owner on Sep 9, 2020. It is now read-only.
Golden file pattern for integration tests, reduced commits #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tro3
changed the title
sdboyer
reviewed
Feb 21, 2017
| if lock != expectedLock { | ||
| t.Fatalf("expected %s, got %s", expectedLock, lock) | ||
| goldenLock := "remove/lock1.golden.json" | ||
| wantLock := strings.Replace(h.GetTestFileString(goldenLock), "` + sysCommit + `", sysCommit, 1) |
There was a problem hiding this comment.
It's not great that we're still having to do this. I've opened #255 to get rid of it.
|
This LGTM - thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving remaining integration tests to golden file pattern. For some reason, the remove_test.go is now passing on my PC, despite nothing being commented out or skipped. We'll see if Appveyor believes the same.