gps: remove unused gopkgin code #1447
Conversation
| // this should only be reachable if there's an error in the regex | ||
| return nil, fmt.Errorf("could not parse %q as a gopkg.in major version", majorStr[1:]) | ||
| } | ||
|
|
||
| mb := make(maybeSources, len(gopkginSchemes)) |
There was a problem hiding this comment.
Why are we modifying a github url with gopkginSchemes?
There was a problem hiding this comment.
It's supposed to be a conservative approach, mirroring gopkg.in's current behavior most closely: the real, running service supports only http and https, not ssh or git.
|
Codeclimate is a bit overzealous |
|
It looks like the dead code was reactivated/fixed since the time I originally branched. Closing. Still seems like there is an opportunity for better shared caching. |
|
yeah, I was confused by this PR - I'm not sure what would have changed to either deactivate or reactivate it. in any case, yes, there's certainly opportunity here for more sharing; it's always been the difficulty of maintaining thread safety and non-duplication guarantees while having to operate without the information yielded by the maybeSource.try() implementations...and the fact that the inputs (especially with gopkg.in's filtered version lists) can influence source return values. |
What does this do / why do we need it?
This PR removes unused gopkgin code. Special case gopkgin types were used to augment normal git behavior, but they were being given standard github urls, so the special case code was not relevant. Now gopkgin imports map directly to their github source, avoiding duplication/isolation for each unique gopkgin import.
Which issue(s) does this PR fix?
Towards #1250 and #431