This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1k
Init (or start of one) #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradfitz
reviewed
Nov 30, 2016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"its" own line.
This is incomplete, but starting to work towards something real
oh, i think we forgot to pull out pkg/errors |
oh wait, no, seems like that was intentional, it got its very own commit. i thought you were just using it for temporary debugging purposes? i've have no problem with adding it for real, just want to make sure we're doing that intentionally. |
@bradfitz sorry, i'm not sure what this means? the review doesn't seem to be linked to any code...though i'm pretty green with github's new code review system |
@freeformz ok, def not worth quibbling over - 👍 i'm sure we'll see less temporary-debuggy use for it later. |
zbintliff
added a commit
to zbintliff/dep
that referenced
this pull request
Mar 3, 2017
Init (or start of one)
ibrasho
pushed a commit
to ibrasho-forks/dep
that referenced
this pull request
May 10, 2017
Init (or start of one)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.