Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Init (or start of one) #14

Merged
merged 5 commits into from
Nov 30, 2016
Merged

Init (or start of one) #14

merged 5 commits into from
Nov 30, 2016

Conversation

freeformz
Copy link

No description provided.

Copy link

@bradfitz bradfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"its" own line.

Edward Muller added 4 commits November 29, 2016 18:08
@sdboyer
Copy link
Member

sdboyer commented Nov 30, 2016

oh, i think we forgot to pull out pkg/errors

@sdboyer
Copy link
Member

sdboyer commented Nov 30, 2016

oh wait, no, seems like that was intentional, it got its very own commit. i thought you were just using it for temporary debugging purposes?

i've have no problem with adding it for real, just want to make sure we're doing that intentionally.

@sdboyer
Copy link
Member

sdboyer commented Nov 30, 2016

"its" own line.

@bradfitz sorry, i'm not sure what this means? the review doesn't seem to be linked to any code...though i'm pretty green with github's new code review system

@freeformz
Copy link
Author

@sdboyer @bradfitz was commenting on a commit message. I fixed it and force pushed.

WRT pkg/errors. I'm a fan, so for now wanted to leave it in. The markup sucks atm, but It's probably useful later. But I'm not against removing it again later either instead.

@sdboyer
Copy link
Member

sdboyer commented Nov 30, 2016

@freeformz ok, def not worth quibbling over - 👍 i'm sure we'll see less temporary-debuggy use for it later.

@sdboyer sdboyer merged commit ed8adfe into master Nov 30, 2016
@jessfraz jessfraz deleted the init branch December 2, 2016 00:15
zbintliff added a commit to zbintliff/dep that referenced this pull request Mar 3, 2017
ibrasho pushed a commit to ibrasho-forks/dep that referenced this pull request May 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants