gps: ./hack/lint.bash fixes

[jmank88]

What does this do / why do we need it?

This PR fixes ./hack/lint.bash failures, by directly returning errors and removing ignoring unused functions/types from prune.go.

Do you need help or clarification on anything?

Should the errors be wrapped?

[sdboyer]

we just added the prune funcs - I don't know why the linters are complaining about unused exported funcs (also, wait what, I thought we had tests for those funcs), but we need to keep those. if we have failures, we need to add exceptions for them to the linters, not remove the code

[sdboyer]

the other change is 👍 though

[jmank88]

I don't know why the linters are complaining about unused exported funcs

Because they are internal?

[sdboyer]

linters generally only take the current package scope into context, since they operate on a per package basis. so, maybe? but it wouldn't be my first guess

…

On September 24, 2017 9:03:35 AM EDT, Jordan Krage ***@***.***> wrote: > I don't know why the linters are complaining about unused exported funcs Because they are internal? -- You are receiving this because your review was requested. Reply to this email directly or view it on GitHub: #1217 (comment)

[jmank88]

https://github.com/dominikh/go-tools/tree/master/cmd/unused#whole-program-analysis

[ibrasho]

(also, wait what, I thought we had tests for those funcs)

I knew something was missing... 🤦‍♂️