-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
acme/autocert: Enable custom ports #69
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: 5dd1a0f) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/crypto/+/155744 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/155744. |
Message from Katie Hockman: Patch Set 1: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/155744. |
Message from Gobot Gobot: Patch Set 1: TryBots beginning. Status page: https://farmer.golang.org/try?commit=2c5d131a Please don’t reply on this GitHub thread. Visit golang.org/cl/155744. |
Message from Gobot Gobot: Patch Set 1: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/155744. |
Message from Katie Hockman: Patch Set 1: Since this is a non-trivial change, please associate this change with an issue that describes the decision from the code owners. If possible, please also include/update any tests. Please don’t reply on this GitHub thread. Visit golang.org/cl/155744. |
This PR (HEAD: f77e8f7) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/crypto/+/155744 to see it. Tip: You can toggle comments from me using the |
Message from Brad Fitzpatrick: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/155744. |
Message from Axel Gluth: Patch Set 3: (1 comment) Reply to comments Please don’t reply on this GitHub thread. Visit golang.org/cl/155744. |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/155744. |
Message from Go Bot: Patch Set 1: TryBots beginning. Status page: https://farmer.golang.org/try?commit=2c5d131a Please don’t reply on this GitHub thread. Visit golang.org/cl/155744. |
Message from Go Bot: Patch Set 1: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/155744. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/155744. |
Message from Katie Hockman: Patch Set 1: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/155744. |
Message from Gopher Robot: Patch Set 1: TryBots beginning. Status page: https://farmer.golang.org/try?commit=2c5d131a Please don’t reply on this GitHub thread. Visit golang.org/cl/155744. |
Message from Gopher Robot: Patch Set 1: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/155744. |
Message from Katie Hockman: Patch Set 1: Since this is a non-trivial change, please associate this change with an issue that describes the decision from the code owners. If possible, please also include/update any tests. Please don’t reply on this GitHub thread. Visit golang.org/cl/155744. |
Message from Brad Fitzpatrick: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/155744. |
Message from Axel Gluth: Patch Set 3: (1 comment) Reply to comments Please don’t reply on this GitHub thread. Visit golang.org/cl/155744. |
It is mandatory to be reachable on port 443 from the public internet but it is completely fine to run a service on a different port internally and use e. g. NAT/masquerading.
Additionally I might want to bind a service not to all of my local IP addresses.
Fixes issue #29540