Skip to content

Commit

Permalink
dashboard: add new darwin-arm64-11_0-toothrot builder
Browse files Browse the repository at this point in the history
These builders are run by the Go team. They are non-hermetic.

For golang/go#39782

Change-Id: Ie402faf9a92ff6c667c8da6fc0dac8528331df48
Reviewed-on: https://go-review.googlesource.com/c/build/+/278432
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
  • Loading branch information
toothrot committed Dec 15, 2020
1 parent 7ff1f94 commit 9ad13ba
Showing 1 changed file with 22 additions and 3 deletions.
25 changes: 22 additions & 3 deletions dashboard/builders.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,8 @@ import (
// syntax entirely. This is a first draft.
var slowBotAliases = map[string]string{
// Known missing builders:
"darwin-arm": "", // TODO(golang.org/issue/37611): Remove once port is removed.
"darwin-arm64": "", // TODO(golang.org/issue/39782): Add builder for darwin/arm64.
"ios-amd64": "", // There is no builder for the iOS Simulator. See issues 42100 and 42177.
"darwin-arm": "", // TODO(golang.org/issue/37611): Remove once port is removed.
"ios-amd64": "", // There is no builder for the iOS Simulator. See issues 42100 and 42177.

"386": "linux-386",
"aix": "aix-ppc64",
Expand All @@ -42,6 +41,7 @@ var slowBotAliases = map[string]string{
"darwin": "darwin-amd64-10_14",
"darwin-386": "darwin-386-10_14", // TODO(golang.org/issue/37610): Remove when Go 1.14 is no longer supported.
"darwin-amd64": "darwin-amd64-10_14",
"darwin-arm64": "darwin-arm64-11_0-toothrot",
"ios-arm64": "ios-arm64-corellium",
"dragonfly": "dragonfly-amd64",
"freebsd": "freebsd-amd64-12_0",
Expand Down Expand Up @@ -511,6 +511,15 @@ var Hosts = map[string]*HostConfig{
SSHUsername: "gopher",
HermeticReverse: true, // we destroy the VM when done & let cmd/makemac recreate
},
"host-darwin-arm64-11_0-toothrot": &HostConfig{
IsReverse: true,
ExpectNum: 2,
Notes: "macOS Big Sur (11.0) ARM64 (M1). Mac mini",
env: []string{
"GOROOT_BOOTSTRAP=/Users/gopher/goboot",
},
SSHUsername: "gopher",
},
"host-linux-s390x": &HostConfig{
Notes: "run by IBM",
OwnerGithub: "ruixin-bao",
Expand Down Expand Up @@ -2286,6 +2295,16 @@ func init() {
distTestAdjust: noTestDirAndNoReboot,
env: []string{"CGO_ENABLED=0"},
})
addBuilder(BuildConfig{
Name: "darwin-arm64-11_0-toothrot",
HostType: "host-darwin-arm64-11_0-toothrot",
distTestAdjust: macTestPolicy,
buildsRepo: func(repo, branch, goBranch string) bool {
// Darwin ARM64 added in Go 1.16.
return atLeastGo1(goBranch, 16) && defaultPlusExpBuild(repo, branch, goBranch)
},
KnownIssue: 39782,
})
addBuilder(BuildConfig{
Name: "darwin-amd64-race",
HostType: "host-darwin-10_15",
Expand Down

0 comments on commit 9ad13ba

Please sign in to comment.