Refactor runMigrations and related provider methods #661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2001781023
💛 - Coveralls |
obalunenko
reviewed
Dec 16, 2021
* Channel migrations instead of interfaces * Handle creating & closing the channel inside runMigrations * Handle reader errors using a separate channel
svekko
force-pushed
the
refactor_run_migration
branch
from
cf274d6 to
2d259aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Migrationinstead ofinterfaceonretchannel.retchannel insiderunMigrations.read,readUp,readDown) has finished its job. Before the provider kept running in the background as there was nothing signalling it to exit.versionCleanfor internal use.