add ed25519 support #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org>
Collaborator
|
Thank you for porting this to the new repo! |
oxisto
requested changes
Jul 27, 2021
oxisto
reviewed
Jul 27, 2021
Contributor
Author
|
done |
vtolstov
commented
Jul 28, 2021
Contributor
Author
vtolstov
left a comment
vtolstov
left a comment
There was a problem hiding this comment.
anything else must be fixed before merge?
Collaborator
Looks good overall, I will check the merge tomorrow. |
oxisto
reviewed
Jul 29, 2021
Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org>
Closed
oxisto
approved these changes
Jul 29, 2021
Closed
Collaborator
|
LGTM, I will give the others, @mfridman @Waterdrips @lggomez some time to object, as we agreed on having two approvals ideally. Otherwise, we can merge this in over the weekend. |
Contributor
Author
|
also will be fine to get new release after this will be merged (to get allocations optimization and eddsa support) |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vasiliy Tolstov v.tolstov@unistack.org