Removing go.mod for v3 releases
#26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in full length here (#17), we have run into issues that forces us to abandon go modules, at least for the `v3.x.x` releases. After this is merged in, we can release a `v3.2.1+incompatible` version, which contains a security fix. Afterwards, we will work on non-breaking quality of life fixes and then eventually run a `v4` version, which most likely will then support go modules and have a new SIV-style import path.
oxisto
force-pushed
the
revert-go-modules-on-v3
branch
7 times, most recently
from
7c73650 to
e36fe85
Compare
oxisto
force-pushed
the
revert-go-modules-on-v3
branch
from
e36fe85 to
590e8c6
Compare
Waterdrips
approved these changes
May 31, 2021
mfridman
approved these changes
Jun 4, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in full length here (#17), we have run into issues that forces us to abandon go modules, at least for the
v3.x.xreleases. After this is merged in, we can release av3.2.1+incompatibleversion, which contains a security fix.Afterwards, we will work on non-breaking quality of life fixes and then eventually run a
v4version, which most likely will then support go modules and have a new SIV-style import path.Also note that according to https://blog.golang.org/go116-module-changes, building from $GOPATH will be removed in Go 1.17. So most likely, only the
v4SIV-style releases will be supported by Go 1.17. However, I can not find anything with regards to this on the upcoming release notes (http://tip.golang.org/doc/go1.17)