Skip to content

Validation Options - Experiment 3 : Introducing new (optional) ClaimsWithOptions interface next to Claims #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

oxisto
Copy link
Collaborator

@oxisto oxisto commented May 28, 2022

This PR is part of a series of experiments, to see which options we have to implement validation options in a backwards compatible way. I want to get a fell about our options first and some feedback from the community, before we implement all desired options. I am looking to gather feedback here: #211

Option 3 is to create a new ClaimsWithOptions interface next to Claims, which provides an additional ValidWithOptions function in the claims to check validations with options. Valid is then redirected to ValidWithOptions

Pros:

  • Should not break anything and seems to be transparent to the user

Cons:

  • It's kind of a mess behind the scenes and it introduces a new interface that is sort of a workaround that we might want to get rid of in v5 again if we decide to break the api and just supply options to Valid directly.

@oxisto oxisto force-pushed the validation-opts-experiment-3 branch from aca38bf to 506e96f Compare May 28, 2022 20:25
@oxisto oxisto changed the title Introducing new ValidWithOptions interface Validation Options - Experiment 3 : Introducing new (optional) ClaimsWithOptions interface next to Claims May 28, 2022
@oxisto oxisto force-pushed the validation-opts-experiment-3 branch from 506e96f to 03ffd83 Compare May 28, 2022 20:33
@oxisto
Copy link
Collaborator Author

oxisto commented Aug 27, 2022

Closing this for now as we are preparing for a new v5 api-breaking solution.

@oxisto oxisto closed this Aug 27, 2022
@oxisto oxisto deleted the validation-opts-experiment-3 branch March 27, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant