Support ExpandHKDF with zero-length keys #330
Merged
+32
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karianna
approved these changes
Dec 1, 2025
dagood
approved these changes
Dec 2, 2025
Co-authored-by: Davis Goodin <dagood@users.noreply.github.com>
gdams
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream Go supports passing
0as key length inhkdf.Expand, and a test exercising this case has been recently added to .OpenSSL doesn't like zero-length inputs, so we better don't call OpenSSL in this case and directly return an empty slice (which is the correct result).
While here, remove an unused parameter.