Move error handling to the autogenerated Go code #262
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a first step to solve #231. Now the Go autogenerated code is in charge of constructing a Go error from a OpenSSL error, which is still done using the
newOpenSSLError
function.This PR shouldn't modify behavior, except for the few places we were previously omitting the error, but now we don't to make the code more robust.
The main benefit of this PR (other than helping fixing #231) is that it is no longer the developer responsibility to correctly construct a Go error when there is an OpenSSL failure. This was a problematic things, as demonstrated by the fact that there were many error handling patterns implemented across the codebase. Now the developer don't have to think about how to construct an error, just pass the autogenerated error up the chain.