fix: nil pointer panic in FOREIGN KEY constraint processing #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalalannn
force-pushed
the
nv/fix_pk_fk
branch
from
d033dad to
f93cec3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed panic that occurred when processing ALTER TABLE ... FOREIGN KEY statements where foreign key column names differ from referenced column names (e.g., referee_id references user_id). The bug was caused by searching for the wrong column name in the source table, resulting in nil pointer dereference. Added proper column lookup using FkAttrs instead of PkAttrs and nil check before accessing column properties.