-
Notifications
You must be signed in to change notification settings - Fork 0
feat: better fonts in mobile ui #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for typetocalculate ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Reviewer's GuideThis PR enhances mobile typography through a new responsive CSS media query and cleans up redundant font rules and formatting in the editor stylesheet; it also augments package.json with serve/watch scripts and dependencies, plus minor test and HTML formatting refinements. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Coverage Report
File CoverageNo changed files found. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @gokulk16 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
"watch": "npm-watch" | ||
"watch": "npm-watch", | ||
"serve": "http-server dist -p 8080 -c-1", | ||
"watch_serve": "nodemon --ext js,html,css --ignore dist/ --exec \"npm run build && npm run serve\"" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Consider using a tool like concurrently for better live reload
Nodemon restarts the full build+serve on each change, causing downtime. A dedicated live-reload watcher (e.g., concurrently or browser-sync) can deliver smoother rebuilds and faster feedback.
Suggested implementation:
"watch_serve": "concurrently -k \"npm run watch\" \"npm run serve\""
- Install concurrently:
npm install --save-dev concurrently - Ensure your package.json has a devDependencies section (or add to dependencies) with:
"concurrently": "^7.6.0" (or latest)
Summary by Sourcery
Improve mobile UI typography and streamline development workflow with responsive styles and new npm scripts
New Features:
Enhancements:
Build: