Skip to content

feat: better fonts in mobile ui #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2025
Merged

feat: better fonts in mobile ui #52

merged 1 commit into from
May 18, 2025

Conversation

gokulk16
Copy link
Owner

@gokulk16 gokulk16 commented May 18, 2025

Summary by Sourcery

Improve mobile UI typography and streamline development workflow with responsive styles and new npm scripts

New Features:

  • Add responsive mobile font-size and line-height settings for editor, output, and history components
  • Introduce "serve" and "watch_serve" npm scripts for local HTTP server and automatic rebuilds

Enhancements:

  • Remove redundant font-size and line-height declarations and reorganize CSS selectors for consistency

Build:

  • Add http-server and nodemon dependencies and configure serve-related scripts in package.json

Copy link

netlify bot commented May 18, 2025

Deploy Preview for typetocalculate ready!

Name Link
🔨 Latest commit b52b5c3
🔍 Latest deploy log https://app.netlify.com/projects/typetocalculate/deploys/682a345d34b7c80008abbdcd
😎 Deploy Preview https://deploy-preview-52--typetocalculate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

sourcery-ai bot commented May 18, 2025

Reviewer's Guide

This PR enhances mobile typography through a new responsive CSS media query and cleans up redundant font rules and formatting in the editor stylesheet; it also augments package.json with serve/watch scripts and dependencies, plus minor test and HTML formatting refinements.

File-Level Changes

Change Details Files
Add responsive mobile typography
  • Introduced media query targeting small screens and coarse pointers
  • Defined oversized font-size and line-height for editor, output, and result-btn
  • Set large font-size and line-height for history elements within mobile context
css/editor.css
Remove redundant font-size and line-height declarations
  • Deleted hardcoded font-size/line-height from body
  • Removed separate font settings from history-label and buttons
  • Merged history-editor-item and history-label selectors into common block
css/editor.css
Improve CSS formatting and grouping
  • Adjusted brace placement and indentation for floating-buttons-row and help-button
  • Normalized comments and whitespace in help-overlay block
  • Reordered selectors to streamline related styles
css/editor.css
Enhance package scripts and dependencies
  • Added serve and combined watch_serve scripts for live build and serve
  • Extended devDependencies with http-server and nodemon
  • Updated watch script to trigger build and serve on changes
package.json
Refine test and HTML formatting
  • Compressed multiline loader test HTML into a single line
  • Inserted consistent blank line in index.html head section
js/loader.test.js
html/index.html

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 61.02%
🟰 ±0%
877 / 1437
🔵 Statements 61.02%
🟰 ±0%
877 / 1437
🔵 Functions 63.75%
🟰 ±0%
51 / 80
🔵 Branches 76.16%
⬆️ +0.73%
131 / 172
File CoverageNo changed files found.
Generated in workflow #87 for commit b52b5c3 by the Vitest Coverage Report Action

@gokulk16 gokulk16 merged commit 3fcb769 into main May 18, 2025
8 checks passed
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @gokulk16 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

"watch": "npm-watch"
"watch": "npm-watch",
"serve": "http-server dist -p 8080 -c-1",
"watch_serve": "nodemon --ext js,html,css --ignore dist/ --exec \"npm run build && npm run serve\""
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Consider using a tool like concurrently for better live reload

Nodemon restarts the full build+serve on each change, causing downtime. A dedicated live-reload watcher (e.g., concurrently or browser-sync) can deliver smoother rebuilds and faster feedback.

Suggested implementation:

    "watch_serve": "concurrently -k \"npm run watch\" \"npm run serve\""

  1. Install concurrently:
    npm install --save-dev concurrently
  2. Ensure your package.json has a devDependencies section (or add to dependencies) with:
    "concurrently": "^7.6.0" (or latest)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant