dark css theme version 0.1

[savez]

Created dark theme version 0.1

reference issue #17

[goksan]

Hi @savez, thanks for the PR

How’s it going? Do you have any details or images to share?

Let me know if you need any help

[savez]

[savez]

I was thinking that perhaps one could use the css function light-dark() (https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/light-dark) so as to have only one CSS and use the colour-scheme proprity to make the switch.

what do you think?

[goksan]

Sure, that sounds like it works

[savez]

Good, I implement it and update PR

[savez]

@goksan I change it.

[goksan]

Thank you! If you're done with it I'll try and take a proper look later this week, and experiment with some of the colours

Thanks again

[goksan]

Did you intentionally commit sizing & font changes?

[savez]

Yes, I think that this UI are good for more screen size.

[savez]

I think a button for switching the theme should be added in the interface.
what do you think?

[goksan]

Would be helpful for users that want to override their OS default

[savez]

@goksan added toggle button

[goksan]

Ok, have you made all your changes?

[savez]

I think yes

[goksan]

Are these changes generated by AI?

[savez]

Are these changes generated by AI?

no, it is my development

[goksan]

Why does the light theme look like this?

This does not default to light/dark based on the OS theme.

The selected theme is lost when you navigate to any other page. Maybe you didn't get around to this, but you haven't provided any detail to suggest this.

I'm not a fan of the sizing changes, and those weren't initially mentioned until I spotted them. Same goes for the font changes.

I'm not going to merge this in its current state. I appreciate you have taken the time to make these current changes, but I also have to take time to review them and a lot of key info has been missing.

[goksan]

color-scheme is duplicated, this is 1

[goksan]

color-scheme is duplicated, this is 2

[goksan]

there's a bunch of places where extra indentation has been added

[savez]

I check your comment and I will implement the necessary changes. thank you!

[savez]

Why does the light theme look like this?

This does not default to light/dark based on the OS theme.

The selected theme is lost when you navigate to any other page. Maybe you didn't get around to this, but you haven't provided any detail to suggest this.

I'm not a fan of the sizing changes, and those weren't initially mentioned until I spotted them. Same goes for the font changes.

I'm not going to merge this in its current state. I appreciate you have taken the time to make these current changes, but I also have to take time to review them and a lot of key info has been missing.

I'm sorry for the bugs. I will implement the necessary changes

For the font I not change it

For the font-site I changed it because I had thought it was better for the view of the data

[savez]

Hi,
I am sorry for the error into prev PR.

I don't seen that you use HTMX for system routing and my implementation didn’t work.

I correct it and I added afterSwap event for manage theme selector.

I hope that this implementation it is ok for you.

Bye

[goksan]

I've had a quick look and issues remain from my prior comments.

Why does the light theme look like this?

It still looks like this?

This does not default to light/dark based on the OS theme.

This still seems to be the case.

The selected theme is lost when you navigate to any other page. Maybe you didn't get around to this, but you haven't provided any detail to suggest this.

Navigating backwards or forwards between pages while in dark mode causes the page you land on to be displayed in light mode.

I'm not a fan of the sizing changes, and those weren't initially mentioned until I spotted them. Same goes for the font changes.

For the font I not change it

To be clear I was referring to font size & weight.

[savez]

Hello,
the font (weights etc.) I changed them because it seems more readable to me.

I'll post a video so you can see that browsing remains the dark theme.

The theme type is saved in localStorage and stays saved there.

only the login is in light theme but by choice. It is not nice to give in login the ability to change theme.

statusnook.mov

[goksan]

Hello, the font (weights etc.) I changed them because it seems more readable to me.

To be clear - I'm not looking to change that at this time.

I think you've changed the background and icon colours, surely you can agree this isn't an improvement?

I'll post a video so you can see that browsing remains the dark theme.

To be clear - you need to navigate backwards and forwards using the back or forward button in your browser to reproduce the issue. I've included a video demonstrating this.

navigation-theme-bug.mp4

It is not nice to give in login the ability to change theme.

You probably don't need to change theme on the login screen, I agree, but I would expect it to use the theme I've selected.

[savez]

ok, thanks epr for the clarification. I will check for the theme and browser navigation keys

I'm sorry

[goksan]

Thank you for your time, but I won't be merging this PR.

[savez]

@goksan

HTMX is probably the problem.

I have made changes to handle:

• system preference
• navigation with browser keys

I then found this plugin “https://unpkg.com/dark-mode-toggle” which works and seems much more convenient for management.

I'll go over a PR if you want.

[goksan]

I don't think such a plugin is necessary here

[savez]

The plugin was an example for the best way for implamentation

Bye