Simpler implementation of dirpreviews
#1958
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From discussion in #1949 (comment)
This is a rewrite of the
dirpreviews
feature, which was originally implemented in #842. This has a number of improvements:loading
property of adir
struct now properly indicates whether it has been read from the filesystem, and is not confused with whether its preview has loaded or not.For the purposes of release notes, technically there is a bug fix in this change:
previewer
script is now only invoked for the current directory (not all directories), when startinglf
withdirpreviews
enabled.