Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Doesn't react on keyboard input after running any shell command with shell-wait #677

Closed
jdfa opened this issue Aug 5, 2021 · 5 comments
Labels

Comments

@jdfa
Copy link

jdfa commented Aug 5, 2021

This issue appeared for me after upgrade to version 0.23, also reproduced on 0.24.
When I run any shell command with shell-wait - I am getting some results and string "Press any key to continue".
After pressing it - main view is rendered, but keys are not working. I can only end lf task to proceed working in terminal.

@gokcehan gokcehan added the bug label Aug 6, 2021
@gokcehan
Copy link
Owner

gokcehan commented Aug 6, 2021

@jdfa We bumped our tcell version in r23 which is probably related to this issue.

@elmarsto
Copy link

This also affects e.g. cmd open $nvim $fx . You can edit the file okay, but after nvim quits, you're froze.

To be clear: the impact of this bug is that, for most use cases, lf no longer works on Windows.

That should be mentioned in capital letters at the top of README.md so no one else wastes the hour I just did ;D

All that said, I love this program and use it constantly on linux. I will miss it at work ;_;

@gokcehan
Copy link
Owner

@elmarsto You're perfectly right to be frustrated. I agree this bug makes the program pretty much useless on windows. It has been bothering me a lot as well. I was hoping to fix it before the latest release but upgrading tcell did not fix the issue and the release has been hanging for quite a while so I decided to push the release as it is. Today, I have taken a look at this again and it seems that event polling goroutine exits after suspend/resume on windows due to tcell.PollEvent returning nil on windows. I have now changed the logic here to fix the issue. It seems to work as intended on my windows and linux. I'm thinking of waiting a couple of days before pushing a new bug fix release to make sure I have not broken anything obvious.

@elmarsto
Copy link

Thank you so much for this quick reply :) I appreciate you taking a further look at this, and it sounds like you have it in hand. If you need someone to help bug-bash it, lmk.

@gokcehan
Copy link
Owner

I have pushed a new release r26 with the fix today. Closing this issue now. Feel free to report back here if the issue persists for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants