Skip to content
This repository has been archived by the owner on Dec 7, 2019. It is now read-only.

Added logging for stop steps. #24

Merged
merged 2 commits into from
Jul 4, 2017

Conversation

yunikkk
Copy link
Contributor

@yunikkk yunikkk commented Jun 28, 2017

Closes #23

Copy link
Contributor

@artem-zinnatullin artem-zinnatullin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, few nits


connectedEmulators()
.map { emulators ->
log("Stop running emulators: $emulators.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stopping

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

.doOnCompleted { log("All emulators stopped") }
.await()
.flatMapCompletable(Completable::merge)
.doOnError { log("Error stopping emulators, error = $it.") }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Error during stopping running emulators, error $it."?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@yunikkk
Copy link
Contributor Author

yunikkk commented Jul 2, 2017

@artem-zinnatullin PTAL

.doOnCompleted { log("All emulators stopped.") }
.await()

log("Swarmer: - \"My job is done here, took ${(System.nanoTime() - startTime).nanosAsSeconds()} seconds, bye bye.\"")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I guess we'll need to extract this log to a separate function, but we could do it later

@artem-zinnatullin artem-zinnatullin merged commit c9f41c1 into gojuno:master Jul 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants