-
Notifications
You must be signed in to change notification settings - Fork 17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, few nits
|
||
connectedEmulators() | ||
.map { emulators -> | ||
log("Stop running emulators: $emulators.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stopping
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
.doOnCompleted { log("All emulators stopped") } | ||
.await() | ||
.flatMapCompletable(Completable::merge) | ||
.doOnError { log("Error stopping emulators, error = $it.") } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Error during stopping running emulators, error $it."?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
@artem-zinnatullin PTAL |
.doOnCompleted { log("All emulators stopped.") } | ||
.await() | ||
|
||
log("Swarmer: - \"My job is done here, took ${(System.nanoTime() - startTime).nanosAsSeconds()} seconds, bye bye.\"") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I guess we'll need to extract this log to a separate function, but we could do it later
Closes #23