Added option to stop emulators. (#15) #16
Conversation
| JCommander(JCommanderArgs()).usage() | ||
| System.exit(0) | ||
| } | ||
|
|
||
| if (COMMAND_STOP_NAMES.firstOrNull { rawArgs.contains(it) } != null) { | ||
| stopAllEmulators().toBlocking().firstOrDefault(Unit) |
There was a problem hiding this comment.
Oh, let's move it to main(), parseArgs() should definitely not be doing anything like that
Maybe return sealed class of parse result?
There was a problem hiding this comment.
Makes sense, thought about it. Decided to go easy way, though=\
There was a problem hiding this comment.
Hah, it'd never easy man, never easy
| .map { emulator -> | ||
| process( | ||
| listOf(adb, "-s", emulator.id, "emu", "kill"), | ||
| timeout = 5 to SECONDS |
There was a problem hiding this comment.
Hm, I'm pretty sure we'll overpass this timeout on our highloaded CI
There was a problem hiding this comment.
I guess something like 15 seconds would be a better default?
| private fun connectedEmulators(): Observable<Iterable<AdbDevice>> = | ||
| connectedAdbDevices().map { it.filter { it.isEmulator } } | ||
|
|
||
| fun stopAllEmulators(): Observable<Unit> = |
There was a problem hiding this comment.
Maybe Completable?
yunikkk
force-pushed
the
add-stop-emulator-option
branch
from
3c7b72c to
b795c4e
Compare
| @@ -2,7 +2,7 @@ ext.versions = [ | |||
| kotlin : '1.1.1', | |||
|
|
|||
| rxJava : '1.2.9', | |||
| jCommander : '1.66', | |||
| jCommander : '1.71', | |||
There was a problem hiding this comment.
Old version was hiding JCommander.newBuilder
yunikkk
force-pushed
the
add-stop-emulator-option
branch
2 times, most recently
from
49aacb8 to
20861e8
Compare
yunikkk
force-pushed
the
add-stop-emulator-option
branch
from
20861e8 to
b32d634
Compare
yunikkk
force-pushed
the
add-stop-emulator-option
branch
from
b32d634 to
bb54d0f
Compare
| fun parseStartArguments(rawArgs: List<String>): List<Commands.Start> = | ||
| rawArgs | ||
| .subList(1, rawArgs.size) // skip command | ||
| .fold(ArrayList<ArrayList<String>>()) { accumulator, value -> |
| .map { it.doOnNext { log("Emulator $it is ready.") } } | ||
|
|
||
| Observable.zip(startEmulators, { startedEmulator -> startedEmulator }) | ||
| rawArgs.toList().apply { |
There was a problem hiding this comment.
this is awesome!
| ))) | ||
| } | ||
| } | ||
|
|
||
| fun SpecBody.onEmulatorNameVariants() { |
There was a problem hiding this comment.
lol, we need to del this
| import rx.Single | ||
| import java.util.concurrent.TimeUnit | ||
|
|
||
| class EmulatorsSpec : Spek({ |
No description provided.