refactor: remove loopback device checks from pcap probe files #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CFC4N <cfc4n.cs@gmail.com>
Closed
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
user/module/probe_openssl_pcap.go:49
- The property name 'ifIdex' appears to be a typo. Consider renaming it to 'ifIndex' for clarity.
m.ifIdex = interf.Index
user/module/probe_gotls_pcap.go:46
- The property name 'ifIdex' appears to be a typo. Consider renaming it to 'ifIndex' for clarity.
g.ifIdex = interf.Index
user/module/probe_gnutls_pcap.go:39
- The property name 'ifIdex' appears to be a typo. Consider renaming it to 'ifIndex' for clarity.
m.ifIdex = interf.Index
|
Failed to generate code suggestions for PR |
…ation Ubuntu 20.04 LTS runner will be removed on 2025-04-15. For more details, see actions/runner-images#11101 Signed-off-by: CFC4N <cfc4n.cs@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
setupManagersPcapfunctions across multiple probe implementations to remove special handling for loopback devices. The most important changes include the removal of checks and comments related to loopback interfaces and the deletion of customized TC filter comments.Removal of loopback device handling:
user/module/probe_gnutls_pcap.go: Removed loopback device checks and related comments fromsetupManagersPcapfunction. [1] [2]user/module/probe_gotls_pcap.go: Removed loopback device checks and related comments fromsetupManagersPcapfunction.user/module/probe_openssl_pcap.go: Removed loopback device checks and related comments fromsetupManagersPcapfunction. [1] [2]