style: unified space #612
Draft
style: unified space #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
建议你增加一些这类问题的防范、检测方法，不只是这一次的修复问题。 比如 |
我也想，但不会😞。手工加正则看字符串的时候发现有一些直接全部替换的话，不是部分匹配不到就是直接改得更糟 |
|
看下clang-format是否支持呢？另外，google的编码规范是否采用了你这种标准？ |
google 编码规范完全没有讲字符串内格式化字符应该怎么放，但是多种样式齐聚一堂也不是好做法 |
|
从代码规范上来看，我支持你的这个提议。不过，我期望是形成一套机制，不能只是本次对历史代码的修正，而是对未来新增代码做卡控。 这种机制，最好增加到自动化格式指令中（make format），卡控手段增加到Github Action中。 希望可以往这个方向上尝试， 感谢。 |
|
我会在之后尝试的，但是因为一些原因在最近一段时间是没有时间了 |
|
目前仍未找到合适的工具进行字符串格式化……转为 draft |
调整了一些输出的空格风格，例如把 `str:{f}`、`str :{f}`、`str : {f}` 改为 `str: {f}`。
剪裁没必要的空格，例如部分字符串中间不规律的双重空格、尾部的空格
发现但未在此次 commit 更改，需要讨论的：
pkg/proc/proc_test.go#L40 建议 `:` 换成 `=`
pkg/event_processor/base_event.go#L150-166 + user/config/mysqld.go#L107 两个半型冒号
user/envent/event_gnutls.go#L81-97 `TID` 与 `Type` 位置对调且 `String()` 函数中 TYPE 全大写
user/envent/event_mastersec_gotls.go#L75 Label 似乎缺少半型冒号
user/envent/event_nspr.go#L85 `Payload` 输出似乎缺少换行
user/envent/event_openssl.go#L153-175 `String` 与 `StringHex` 日志输出 `Send`/`Recv` 与 `Version` 位置对调
xxxxxliil
force-pushed
the
unified-space-style
branch
from
e7e7eae
to
14679d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
调整了一些输出的空格风格，例如把
str:{f}、str :{f}、str : {f}改为str: {f}。 剪裁没必要的空格，例如部分字符串中间不规律的双重空格、尾部的空格发现但未在此次 commit 更改，需要讨论的：
pkg/proc/proc_test.go#L40 建议
:换成=pkg/event_processor/base_event.go#L150-166 + user/config/mysqld.go#L107 两个半型冒号
user/envent/event_gnutls.go#L81-97
TID与Type位置对调且String()函数中 TYPE 全大写 user/envent/event_mastersec_gotls.go#L75 Label 似乎缺少半型冒号user/envent/event_nspr.go#L85
Payload输出似乎缺少换行user/envent/event_openssl.go#L153-175
String与StringHex日志输出Send/Recv与Version位置对调