Fix bash module v2 #508
Closed
Fix bash module v2 #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 7, 2024 08:49
cfc4n
requested changes
Mar 7, 2024
| @@ -58,7 +59,7 @@ func bashCommandFunc(command *cobra.Command, args []string) { | |||
| stopper := make(chan os.Signal, 1) | |||
| signal.Notify(stopper, os.Interrupt, syscall.SIGTERM) | |||
| ctx, cancelFun := context.WithCancel(context.TODO()) | |||
|
|
|||
| ctx = context.WithValue(ctx, config.CONTEXT_KEY_MODULE_NAME, module.ModuleNameBash) | |||
There was a problem hiding this comment.
It seems that the code here is not necessary?
| } | ||
|
|
||
| func (bp *BashParser) detect(ctx context.Context, b []byte) error { | ||
| if ctx.Value(config.CONTEXT_KEY_MODULE_NAME) == "EBPFProbeBash" { |
There was a problem hiding this comment.
I think the design here is not elegant. The pkg directory should be a business-independent third-party package, and the config package should not be referenced.
There was a problem hiding this comment.
- In my implementation, it's necessary to determine whether to use the bash parser based on context information.
- When setting a key in the context, it cannot be a string or any other built-in type (see https://staticcheck.io/docs/checks#SA1029).
- Therefore, a custom type contextKey is required, which needs to be introduced in "ecapture/pkg/event_processor" and "ecapture/cli/cmd" as the type for context information keys.
- I didn't delve too deeply into where to define this type in the config package. Where would be the most appropriate place to put it?"
There was a problem hiding this comment.
Indeed, abstraction here is a bit troublesome. I'll think about it later too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #490.
in this PR: