Clean up, update for Django 5, and fix tests #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrcorn
approved these changes
May 21, 2024
This was referenced May 23, 2024
arcticlinux
reviewed
Jul 22, 2024
| @@ -54,14 +55,17 @@ def __init__(self, *args, **kwargs): | |||
| self.max_choices = kwargs.pop('max_choices', None) | |||
| super(MultiSelectField, self).__init__(*args, **kwargs) | |||
| self.max_length = get_max_length(self.choices, self.max_length) | |||
| self.validators[0] = MaxValueMultiFieldValidator(self.max_length) | |||
| self.validators.append(MaxValueMultiFieldValidator(self.max_length)) | |||
There was a problem hiding this comment.
Not sure the best place to mention this, but I was working on this last year, and this changes how the validators work.
The original removes/replaces the existing CharField MaxLengthValidator.
Appending to the validators means that both the CharField MaxLengthValidator and MaxValueMultiFieldValidator are present. Previously if you specified your model without a max_length the max length would be set the length of the longest choice or to the default 200 in get_max_length. Appending causes a validation error when django.core.validators MaxLengthValidator.compare tries to compare model's max_length (None) if you don't supply a max_length in the model.
I changed my fork to use:
self.validators = [v for v in self.validators if not isinstance(v, validators.MaxLengthValidator)]
self.max_length = get_max_length(self.choices, self.max_length)
self.validators.append(MaxValueMultiFieldValidator(self.max_length))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exampleprojectThis removes backwards compatibility code that @goinnn has previously indicated they would rather keep. But the Python ecosystem has moved on so far since Django 1 and 2 and Python 2 that I think it's time to stop supporting those.
Closes #142, #146.