Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Markdown render hooks for tables #12809

Merged
merged 1 commit into from
Aug 31, 2024
Merged

Conversation

bep
Copy link
Member

@bep bep commented Aug 30, 2024

Fixes #9316

@bep bep force-pushed the feat/tablehooks-9316 branch 7 times, most recently from 41c1ecd to 7560f46 Compare August 30, 2024 16:16
@jmooring
Copy link
Member

Ignore this if I am testing too soon, but I'm getting this error when building the docs site:

Error: error building site: render: failed to render pages: render of "term" failed: template: _internal/_default/rss.xml:67:22: executing "_internal/_default/rss.xml" at <.Summary>: error calling Summary: renderer not found

@bep
Copy link
Member Author

bep commented Aug 30, 2024

I don't think you should get that particular error with the current commit, but I would wait for the tests above to go green.

Edit in: No, I get that error when I build the docs site. OK, thanks for the report.

@bep bep force-pushed the feat/tablehooks-9316 branch 4 times, most recently from 4a28a25 to 5a732f9 Compare August 31, 2024 08:48
@bep bep marked this pull request as ready for review August 31, 2024 08:52
@bep
Copy link
Member Author

bep commented Aug 31, 2024

@jmooring I have pushed a fix for the "renderer not found" issue. This PR needs a couple more tests, but should be OK.

@jmooring
Copy link
Member

Looks good to me.

@bep bep merged commit f738669 into gohugoio:master Aug 31, 2024
7 checks passed
jmooring added a commit to jmooring/hugo-docs that referenced this pull request Aug 31, 2024
jmooring added a commit to jmooring/hugo-docs that referenced this pull request Aug 31, 2024
bep pushed a commit to gohugoio/hugoDocs that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown render hook - table
2 participants