Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google_news internal template should be deprecated #9172

Closed
coliff opened this issue Nov 15, 2021 · 1 comment · Fixed by #9190
Closed

google_news internal template should be deprecated #9172

coliff opened this issue Nov 15, 2021 · 1 comment · Fixed by #9190
Assignees
@jmooring
Labels
Feature: Embedded Template Outdated

Comments

@coliff
Copy link
Member

coliff commented Nov 15, 2021

Google News meta tag (news_keywords) hasn't been supported since October 2017.
REF: https://www.seroundtable.com/google-news-meta-keywords-tag-no-longer-supported-25270.html

It doesn't do any harm to include it, but there's no point in doing so. I suggest including it should give a deprecation warning and the internal template should be removed altogether in a future Hugo release.

template:
https://github.com/gohugoio/hugo/blob/master/tpl/tplimpl/embedded/templates/google_news.html
@jmooring jmooring mentioned this issue Nov 20, 2021
Merged
jmooring added a commit to jmooring/hugo that referenced this issue Nov 21, 2021
@jmooring
Add deprecation warning to google_news templates
fb09354 
Closes gohugoio#9172
@jmooring jmooring mentioned this issue Nov 21, 2021
Merged
@jmooring jmooring self-assigned this Nov 21, 2021
jmooring added a commit to jmooring/hugo that referenced this issue Nov 21, 2021
@jmooring
Add deprecation warning to google_news template
aa6fbfc 
Closes gohugoio#9172
jmooring added a commit to gohugoio/hugoDocs that referenced this issue Nov 21, 2021
@jmooring
Remove google_news from list of internal templates (#1576)
91011d2 
Supports gohugoio/hugo#9172
@bep bep closed this as completed in #9190 Nov 21, 2021
bep pushed a commit that referenced this issue Nov 21, 2021
@jmooring @bep
Add deprecation warning to google_news template
75a823a 
Closes #9172
@jmooring jmooring mentioned this issue Dec 12, 2021
Merged
7 tasks
adityatelange pushed a commit to adityatelange/hugo-PaperMod that referenced this issue Dec 12, 2021
@jmooring
Remove call to google_news internal template (#668)
dbaa17c 
See gohugoio/hugo#9172
This was referenced Dec 17, 2021
Closed
Closed
ouuan added a commit to ouuan/hugo-theme-even that referenced this issue Dec 27, 2021
@ouuan
chore: remove google_news
9cb26d5 
See gohugoio/hugo#9172
@timkofu timkofu mentioned this issue Dec 31, 2021
Closed
earlng added a commit to earlng/hugo-theme-chunky-poster that referenced this issue Jan 3, 2022
@earlng
removed google_news template
575e0f8 
In Hugo v0.91.2 google_news template is now deprecated.

WARN 2022/01/03 16:30:06 The google_news internal template will be removed in a future release. Please remove calls to this template. See gohugoio/hugo#9172 for additional information.
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jmooring jmooring

Labels
Feature: Embedded Template Outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add deprecation warning to google_news template jmooring/hugo
2 participants
@jmooring @coliff