Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Goldmark the new default markdown renderer #5963

Closed
bep opened this issue May 16, 2019 · 8 comments
Closed

Make Goldmark the new default markdown renderer #5963

bep opened this issue May 16, 2019 · 8 comments
Labels
Enhancement Outdated
Milestone
v0.61

Comments

@bep
Copy link
Member

bep commented May 16, 2019

https://github.com/yuin/goldmark
@bep bep added this to the v0.56 milestone May 16, 2019
@bep
Copy link
Member Author

bep commented May 16, 2019

I've been looking for a solid CommonMark compliant MD processor for a long time, and from what I've seen the above looks very solid.

/cc @kaushalmodi @spf13 and gang.

/cc @yuin I assume you wouldn't mind if we used this in Hugo? I notice that it's already at > v1 so that looks promising.

@yuin
Copy link

yuin commented May 16, 2019

@bep Yes, goldmark passed all commonmark 0.29 spec tests . Extensions are also tested.

Extensibility that blackfridy does not have should come in useful for applications like Hugo, I would be glad if goldmark could help to Hugo :)

@kaushalmodi
Copy link
Contributor

@bep Looks great! Please let this upgrade marinate in the master branch for a while (1 week or so) so that I can upgrade ox-hugo in parallel to support it.

@bep bep modified the milestones: v0.56, v0.57 Jun 14, 2019
@bep bep modified the milestones: v0.57, v0.58 Jul 31, 2019
@bep bep modified the milestones: v0.58, v0.59, v0.57 Aug 13, 2019
@bep bep pinned this issue Aug 13, 2019
@bep bep mentioned this issue Aug 16, 2019
Closed
@onedrawingperday onedrawingperday mentioned this issue Aug 19, 2019
Closed
@bep bep modified the milestones: v0.58, v0.59 Sep 2, 2019
@dankohn dankohn mentioned this issue Sep 3, 2019
Closed
@bep bep modified the milestones: v0.59, v0.60 Sep 6, 2019
@frank06 frank06 mentioned this issue Sep 19, 2019
Closed
@evankanderson
Copy link
Contributor

Is this in progress or in the icebox pending developer work?

@bep bep changed the title Investigate use of Goldmark Make Goldmark the new default markdown renderer Sep 30, 2019
bep added a commit to bep/hugo that referenced this issue Nov 11, 2019
@bep
Add Goldmark as the new default markdown handler
f9bafca 
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
bep added a commit to bep/hugo that referenced this issue Nov 11, 2019
@bep
Add Goldmark as the new default markdown handler
9fba156 
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
bep added a commit to bep/hugo that referenced this issue Nov 12, 2019
@bep
Add Goldmark as the new default markdown handler
d0fc67d 
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 14, 2019
@bep
Add Goldmark as the new default markdown handler
24aafc4 
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 15, 2019
@bep
Add Goldmark as the new default markdown handler
9c4aa0e 
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 16, 2019
@bep
Add Goldmark as the new default markdown handler
b8c5c5b 
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 16, 2019
@bep
Add Goldmark as the new default markdown handler
cd0067c 
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 17, 2019
@bep
Add Goldmark as the new default markdown handler
46b6e2c 
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 17, 2019
@bep
Add Goldmark as the new default markdown handler
ae78f40 
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 17, 2019
@bep
Add Goldmark as the new default markdown handler
2332537 
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 17, 2019
@bep
Add Goldmark as the new default markdown handler
b34a287 
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 17, 2019
@bep
Add Goldmark as the new default markdown handler
16257f1 
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 17, 2019
@bep
Add Goldmark as the new default markdown handler
a8d3efc 
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
@sephore sephore mentioned this issue Nov 18, 2019
Closed
bep added a commit to bep/hugo that referenced this issue Nov 19, 2019
@bep
Add Goldmark as the new default markdown handler
16f5cc3 
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 19, 2019
@bep
Add Goldmark as the new default markdown handler
9ed8e8e 
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 19, 2019
@bep
Add Goldmark as the new default markdown handler
a07ab3d 
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 19, 2019
@bep
Add Goldmark as the new default markdown handler
362c93b 
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 23, 2019
@bep
Add Goldmark as the new default markdown handler
a7f65bb 
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 23, 2019
@bep
Add Goldmark as the new default markdown handler
1002a66 
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 23, 2019
@bep
Add Goldmark as the new default markdown handler
0738fee 
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 23, 2019
@bep
Add Goldmark as the new default markdown handler
0c9f858 
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 23, 2019
@bep
Add Goldmark as the new default markdown handler
c16562e 
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
@bep bep closed this as completed in bfb9613 Nov 23, 2019
@bep bep unpinned this issue Nov 28, 2019
@gcushen gcushen mentioned this issue Dec 12, 2019
Closed
4 tasks
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Enhancement Outdated
Projects
None yet
Milestone
v0.61
Development

No branches or pull requests
6 participants
@yuin @bep @kaushalmodi @jimangel @evankanderson @scivision