-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an unified .Site.Config with a services section #4751
Comments
bep
added a commit
to bep/hugo
that referenced
this issue
May 22, 2018
bep
added a commit
to bep/hugo
that referenced
this issue
May 22, 2018
bep
added a commit
that referenced
this issue
May 22, 2018
bep
added a commit
that referenced
this issue
May 25, 2018
bep
added a commit
that referenced
this issue
May 25, 2018
We need to revisit and complete that. See #4751
bep
added a commit
that referenced
this issue
May 25, 2018
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
With the recent privacy config addition, we can do:
Working on making "privacy friendly" editions of some of the shortcodes, we need to add some additional service-specific config. This is currently not possible without too much ceremony. It needs to be available from shortcodes and we don't want to add another top level
.Site
field.Back when Hugo was a youngster, it probably made sense to put
DisqusShortname
on the top level site config, but now that looks sub-optimal.We can fix that while keeping the old sites working as before.
It also makes sense to keep the privacy config as one copy-and-paste-friendly entity. So I suggest that we make it so:
Would give two config objects that both relate to
Instagram
.Also, we should make it so
Points to the same value as
.Site.DisqusShortname
(keeping the old, but eventually remove it from the docs).Also consider:
There are other candidates, but those will have to wait.
The text was updated successfully, but these errors were encountered: