isset should return error on integer slices when passed a string value

[bwbecker]

Just updated hugo from 0.19 to 0.25 via "brew upgrade hugo". Ran hugo and got

Started building sites ...
WARNING: calling IsSet with unsupported type "invalid" (<nil>) will always return false.

panic: reflect: call of reflect.Value.Int on string Value [recovered]
	panic: reflect: call of reflect.Value.Int on string Value [recovered]
	panic: reflect: call of reflect.Value.Int on string Value [recovered]
	panic: reflect: call of reflect.Value.Int on string Value

goroutine 133 [running]:
text/template.errRecover(0xc4205cb830)
	/usr/local/Cellar/go/1.8.3/libexec/src/text/template/exec.go:146 +0x62
panic(0x1710e80, 0xc4203649a0)
	/usr/local/Cellar/go/1.8.3/libexec/src/runtime/panic.go:489 +0x2cf
text/template.errRecover(0xc4205cab38)
	/usr/local/Cellar/go/1.8.3/libexec/src/text/template/exec.go:146 +0x62
panic(0x1710e80, 0xc4203649a0)
	/usr/local/Cellar/go/1.8.3/libexec/src/runtime/panic.go:489 +0x2cf

etc.

Uninstalled hugo (brew uninstall --force hugo), reinstalled, with the same result.

MacBook Pro running MacOS 10.12.5.

[bep]

I need more info to guess what this is. Do you have the site source online for people to look at?

[bwbecker]

https://github.com/bwbecker/localpr.ca <https://github.com/bwbecker/localpr.ca>

…

On Jul 7, 2017, at 9:09 AM, Bjørn Erik Pedersen ***@***.***> wrote: I need more info to guess what this is. Do you have the site source online for people to look at? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3681 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA_ZRgtcZV-M6pILIHGpEdu5UAGHVNBPks5sLi4CgaJpZM4OQ2u0>.

--------------------------------------------- Byron Weber Becker School of Computer Science University of Waterloo, Waterloo, Ontario N2L 3G1 Email: bwbecker@uwaterloo.ca Phone: 519-888-4567 x34661 Advising FAQ: www.cs.uwaterloo.ca/current/faq

[bep]

@bwbecker that repository does not build out-of-the box. Probably a missing theme.

[bwbecker]

Sorry; added the theme and pushed. Pulled to a fresh directory. Builds with Hugo v0.19 but gives the panic with Hugo v0.20.

[bep]

@moorereason this test panics for IsSet:

{[]interface{}{1, 2, 3, 5}, "2", false, false, ""},

@bwbecker the panic is unfortunate, and we will fix that, but the .Site.Sections was deprecated in Hugo 0.23 and is now replaced with a slice of Pages, so the isset constructs in your theme does not work anymore. Please take any further questions on https://discourse.gohugo.io/

[bwbecker]

Thank you!

…

On Jul 7, 2017, at 1:18 PM, Bjørn Erik Pedersen ***@***.***> wrote: @moorereason <https://github.com/moorereason> this test fails for IsSet: {[]interface{}{1, 2, 3, 5}, "2", false, false, ""}, @bwbecker <https://github.com/bwbecker> the panic is unfortunate, and we will fix that, but the .Site.Sections was deprecated in Hugo 0.23 and is now replaced with a slice of Pages, so the isset constructs in your theme does not work anymore. Please take any further questions on https://discourse.gohugo.io/ <https://discourse.gohugo.io/> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3681 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA_ZRovAvjW_gWCf6MCvy383-T2S52e0ks5sLmhIgaJpZM4OQ2u0>.

--------------------------------------------- Byron Weber Becker School of Computer Science University of Waterloo, Waterloo, Ontario N2L 3G1 Email: bwbecker@uwaterloo.ca Phone: 519-888-4567 x34661 Advising FAQ: www.cs.uwaterloo.ca/current/faq